Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.Runtime.Metadata IL reader #16440

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

vzarytovskii
Copy link
Member

Description

New IL reader which uses S.R.M, which is faster and more correct. Continuing on top of Will's(@TIHan) work.

Checklist

  • Performance tests (not CI-based, but synthetic ones).
  • Added a compiler switch (off-by-default) which would select old or new reader
  • Test cases added (separate CI leg which will be using --test: flag (see below)
  • --test:* flag which will run both readers and deep-compare their results
  • CI step which will be using said --test flag
  • Release notes entry updated

@vzarytovskii
Copy link
Member Author

Oh well, this didn't go well:

error FS0193: The module/namespace 'RuntimeHelpers' from compilation unit 'FSharp.Core' did not contain the val 'ValLinkagePartialKey(EnumerateTryWith)'

when compiling self

Copy link
Contributor

❗ Release notes required

@vzarytovskii,

Caution

No release notes found for the changed paths (see table below).

Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format.

The following format is recommended for this repository:

* <Informative description>. ([PR #XXXXX](https://github.com/dotnet/fsharp/pull/XXXXX))

See examples in the files, listed in the table below or in th full documentation at https://fsharp.github.io/fsharp-compiler-docs/release-notes/About.html.

If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

You can open this PR in browser to add release notes: open in github.dev

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/8.0.400.md No release notes found or release notes format is not correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New
Development

Successfully merging this pull request may close these issues.

None yet

1 participant