Improve FixAll support by using equivalence key when available #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 2, 2020
jmarolf
approved these changes
Dec 2, 2020
|
@JoeRobich do we want to try and use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating the fixes for these blank line StyleCop rules (#67 (comment)), I saw format was reporting no fixall action returned from the provider. Investigating the StyleCop repo it seemed that an action should be returned. After verifying that the VS Code C# extension could apply a solution fixall for those diagnostics, I looked for differences in implementation. It seems necessary to provide the equivalence key for some fixall providers.