Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #834 : error reportfile without directory specified #842

Merged
merged 2 commits into from Oct 19, 2020
Merged

Fixes #834 : error reportfile without directory specified #842

merged 2 commits into from Oct 19, 2020

Conversation

Styxxy
Copy link
Contributor

@Styxxy Styxxy commented Oct 19, 2020

Fixes #834

JoeRobich
JoeRobich approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@JoeRobich JoeRobich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this issue! Only one suggestion, but I would also accept this fix as is.

src/ReportWriter.cs Outdated Show resolved Hide resolved
JoeRobich
JoeRobich approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@JoeRobich JoeRobich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again. I'll shepard this through our flaky CI today.

@Styxxy
Copy link
Contributor Author

Styxxy commented Oct 19, 2020 •
edited

Thanks @JoeRobich , was wondering if it was something that I broke (which seemed unlikely with the very small code change) 😃 .

@JoeRobich JoeRobich merged commit ea58947 into dotnet:master Oct 19, 2020
@Styxxy Styxxy deleted the bugfixes/834-report-justfilename branch October 19, 2020 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeRobich JoeRobich JoeRobich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using option report with just a filename results in exception
2 participants
@Styxxy @JoeRobich