Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CodeFormatter tests for --fix-style #751

Merged
merged 2 commits into from Aug 11, 2020

Conversation

JoeRobich
Copy link
Member

Related to #717

Adds a project with correct whitespace and some codestyle warnings. Shows that whitespace formatting produces no changes, codestyle error fixing produces no changes, and codestyle warning fixing updates the code in the solution.

Comment on lines -173 to -175
// This flag is used at restore time to avoid imports from packages changing the inputs to restore,
// without this it is possible to get different results between the first and second restore.
{ "ExcludeRestorePackageImports", bool.TrueString },
Copy link
Member Author

@JoeRobich JoeRobich Aug 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This property was stopping NetStandard projects from resolving framework references from the project.assets.json file.

Even with this property removed, a full restore must be run on the project prior to formatting in order to produce this project.assets.json file, otherwise missing framework references will be reported in compiler diagnostics.

Copy link
Contributor

@jmarolf jmarolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@JoeRobich JoeRobich merged commit 6149ab5 into dotnet:master Aug 11, 2020
@JoeRobich JoeRobich deleted the codestyle-unit-tests branch March 5, 2021 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants