Unit test fixes for Windows #1804
Conversation
ghost
added
the
|
@dotnet-policy-service agree |
| } | ||
|
|
||
| } | ||
| "; | ||
|
|
||
| var expectedCode = @" | ||
| // Hack for Windows: StyleCop uses the Environment NewLine for its replacement, |
There was a problem hiding this comment.
Tagging @sharwell to comment on this.
|
Windows tests runs are timing out here. Also seeing a warning in the test project: |
|
Not sure why these changes would be necessary. |
| @@ -86,21 +87,26 @@ void M() | |||
|
|
|||
| int count = 5; | |||
|
|
|||
|
|
|||
| count = 6; | |||
| @@ -163,6 +169,9 @@ void M() | |||
|
|
|||
| // Prefer using. IDISP017 | |||
| ["dotnet_diagnostic.IDISP017.severity"] = "error", | |||
|
|
|||
| // We expect new line as end_of_line in this test | |||
| ["end_of_line"] = EndOfLineFormatter.GetEndOfLineOption("\n"), | |||
| @@ -210,6 +219,9 @@ void M() | |||
|
|
|||
| // Prefer using. IDISP017 | |||
| ["dotnet_diagnostic.IDISP017.severity"] = "error", | |||
|
|
|||
| // We expect new line as end_of_line in this test | |||
| ["end_of_line"] = EndOfLineFormatter.GetEndOfLineOption("\n"), | |||
There was a problem hiding this comment.
❔ Why was this added? This test has expectedCode that relies on the environment newline, and the default end_of_line value would be the same. This test wouldn't have been failing before this change, provided the user on Windows checked out the code with the required core.autocrlf=true configuration.
| sb.Append("Greeter.Greet() -> void"); | ||
| sb.Append(Environment.NewLine); | ||
| sb.Append("Greeter.Greeter() -> void"); | ||
| var expectedPublicApi = sb.ToString(); |
| @@ -41,7 +41,7 @@ class C | |||
|
|
|||
| var editorConfig = new Dictionary<string, string>() | |||
| { | |||
| ["end_of_line"] = EndOfLineFormatter.GetEndOfLineOption(Environment.NewLine), | |||
| ["end_of_line"] = EndOfLineFormatter.GetEndOfLineOption("\n"), | |||
There was a problem hiding this comment.
❔ Why was this changed? Applies to all instances of this in the file.
|
Closing as 9.x development has moved into the dotnet/sdk repo. |
I've made some changes to the unit tests, so that they are all working with windows.
Almost all changes regarded the end-of-line problem between Windows and Linux/Mac.