Add try/catch around FindWorkspace calls to handle FileNotFound #1387
Conversation
|
@jmarolf Please take a look |
| } | ||
| catch (FileNotFoundException fex) | ||
| { | ||
| logger.LogError(fex.Message); |
There was a problem hiding this comment.
shouldn't we show a message saying we couldn't find the file instead of logging an error? Doesn't this still show a stack trace to the user?
There was a problem hiding this comment.
We log the message because the workspace finder throws this exception with different messages based on how it fails. This does not log the stack trace.
There was a problem hiding this comment.
We should rework this to not rely on exception handling but wanted to address the regression.
There was a problem hiding this comment.
since this is in main I am ok with waiting for a full re-work. do we want this to go into the 6.x branch instead?
There was a problem hiding this comment.
Thanks for pointing out wrong base branch. Updated to release/6.x
There was a problem hiding this comment.
alright, I'll email .NET Tactics to see if they want to take this for .NET 6
|
Azure Pipelines successfully started running 2 pipeline(s). |
Resolves #1386