Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Load analyzer assemlbies in their own AssemblyLoadContext
- Loading branch information
Showing
7 changed files
with
137 additions
and
67 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,35 +1,94 @@ | ||
| // Copyright (c) Microsoft. All Rights Reserved. Licensed under the MIT license. See License.txt in the project root for license information. | ||
|
|
||
| using System.Collections.Immutable; | ||
| using System.IO; | ||
| using System.Linq; | ||
| using System.Reflection; | ||
| using Microsoft.CodeAnalysis; | ||
| using Microsoft.CodeAnalysis.CodeFixes; | ||
| using Microsoft.CodeAnalysis.Diagnostics; | ||
| using System.Runtime.Loader; | ||
| using Microsoft.Extensions.Logging; | ||
|
|
||
| namespace Microsoft.CodeAnalysis.Tools.Analyzers | ||
| { | ||
| internal class AnalyzerReferenceInformationProvider : IAnalyzerInformationProvider | ||
| { | ||
| public (ImmutableArray<DiagnosticAnalyzer> Analyzers, ImmutableArray<CodeFixProvider> Fixers) GetAnalyzersAndFixers( | ||
| public ImmutableDictionary<Project, AnalyzersAndFixers> GetAnalyzersAndFixers( | ||
| Solution solution, | ||
| FormatOptions formatOptions, | ||
| ILogger logger) | ||
| { | ||
| if (!formatOptions.FixAnalyzers) | ||
| { | ||
| return (ImmutableArray<DiagnosticAnalyzer>.Empty, ImmutableArray<CodeFixProvider>.Empty); | ||
| return ImmutableDictionary<Project, AnalyzersAndFixers>.Empty; | ||
| } | ||
|
|
||
| var assemblies = solution.Projects | ||
| .SelectMany(project => project.AnalyzerReferences.Select(reference => reference.FullPath)) | ||
| .Distinct() | ||
| .Select(path => Assembly.LoadFrom(path)); | ||
| return solution.Projects | ||
| .ToImmutableDictionary(project => project, GetAnalyzersAndFixers); | ||
| } | ||
|
|
||
| private AnalyzersAndFixers GetAnalyzersAndFixers(Project project) | ||
| { | ||
| var analyzerAssemblies = project.AnalyzerReferences | ||
| .Select(reference => TryLoadAssemblyFrom(reference.FullPath)) | ||
| .OfType<Assembly>() | ||
| .ToImmutableArray(); | ||
|
|
||
| return AnalyzerFinderHelpers.LoadAnalyzersAndFixers(analyzerAssemblies); | ||
| } | ||
|
|
||
| private Assembly? TryLoadAssemblyFrom(string? path) | ||
| { | ||
| // Since we are not deploying these assemblies we need to ensure the files exist. | ||
| if (path is null || !File.Exists(path)) | ||
| { | ||
| return null; | ||
| } | ||
|
|
||
| try | ||
| { | ||
| var context = new AnalyzerLoadContext(Path.GetDirectoryName(path)); | ||
|
|
||
| // First try loading the assembly from disk. | ||
| return context.LoadFromAssemblyPath(path); | ||
| } | ||
| catch { } | ||
|
|
||
| return AnalyzerFinderHelpers.LoadAnalyzersAndFixers(assemblies); | ||
| // Give up. | ||
| return null; | ||
| } | ||
|
|
||
| public DiagnosticSeverity GetSeverity(FormatOptions formatOptions) => formatOptions.AnalyzerSeverity; | ||
|
|
||
| internal sealed class AnalyzerLoadContext : AssemblyLoadContext | ||
| { | ||
| private readonly string _assemblyFolderPath; | ||
|
|
||
| public AnalyzerLoadContext(string assemblyFolderPath) | ||
| { | ||
| _assemblyFolderPath = assemblyFolderPath; | ||
| } | ||
|
|
||
| protected override Assembly Load(AssemblyName assemblyName) | ||
| { | ||
| // Since we build against .NET Core 2.1 we do not have access to the | ||
| // AssemblyDependencyResolver which resolves depenendency assembly paths | ||
| // from AssemblyName by using the .deps.json. | ||
|
|
||
| // We will instead do the simplest thing by looking for the requested assembly | ||
| // by name in the same folder as the assembly being loaded. | ||
| var possibleAssemblyFileName = $"{assemblyName.Name}.dll"; | ||
| var possibleAssemblyPath = Path.Combine(_assemblyFolderPath, possibleAssemblyFileName); | ||
| try | ||
| { | ||
| if (File.Exists(possibleAssemblyPath)) | ||
| { | ||
| return LoadFromAssemblyPath(possibleAssemblyPath); | ||
| } | ||
| } | ||
| catch { } | ||
|
|
||
| // Try to load the requested assembly from the default load context. | ||
| return AssemblyLoadContext.Default.LoadFromAssemblyName(assemblyName); | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| // Copyright (c) Microsoft. All Rights Reserved. Licensed under the MIT license. See License.txt in the project root for license information. | ||
|
|
||
| using System.Collections.Immutable; | ||
| using Microsoft.CodeAnalysis.CodeFixes; | ||
| using Microsoft.CodeAnalysis.Diagnostics; | ||
|
|
||
| namespace Microsoft.CodeAnalysis.Tools.Analyzers | ||
| { | ||
| internal struct AnalyzersAndFixers | ||
| { | ||
| public ImmutableArray<DiagnosticAnalyzer> Analyzers { get; } | ||
| public ImmutableArray<CodeFixProvider> Fixers { get; } | ||
|
|
||
| public AnalyzersAndFixers(ImmutableArray<DiagnosticAnalyzer> analyzers, ImmutableArray<CodeFixProvider> fixers) | ||
| { | ||
| Analyzers = analyzers; | ||
| Fixers = fixers; | ||
| } | ||
|
|
||
| public void Deconstruct( | ||
| out ImmutableArray<DiagnosticAnalyzer> analyzers, | ||
| out ImmutableArray<CodeFixProvider> fixers) | ||
| { | ||
| analyzers = Analyzers; | ||
| fixers = Fixers; | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.