Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use placeholder value to fix CredScan #33550

Merged
merged 1 commit into from Apr 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
43 changes: 0 additions & 43 deletions .config/guardian/.gdnbaselines

This file was deleted.

2 changes: 1 addition & 1 deletion azure-pipelines-public.yml
Expand Up @@ -211,6 +211,6 @@ stages:
env:
HelixAccessToken: $(_HelixAccessToken)
SYSTEM_ACCESSTOKEN: $(System.AccessToken) # We need to set this env var to publish helix results to Azure Dev Ops
MSSQL_SA_PASSWORD: "Password12!"
MSSQL_SA_PASSWORD: "PLACEHOLDER"
COMPlus_EnableWriteXorExecute: 0 # Work-around for https://github.com/dotnet/runtime/issues/70758
DotNetBuildsInternalReadSasToken: $(dotnetbuilds-internal-container-read-token)
2 changes: 1 addition & 1 deletion azure-pipelines.yml
Expand Up @@ -238,7 +238,7 @@ extends:
HelixAccessToken: $(_HelixAccessToken)
# We need to set this env var to publish helix results to Azure Dev Ops
SYSTEM_ACCESSTOKEN: $(System.AccessToken)
MSSQL_SA_PASSWORD: "Password12!"
MSSQL_SA_PASSWORD: "PLACEHOLDER"
# Work-around for https://github.com/dotnet/runtime/issues/70758
COMPlus_EnableWriteXorExecute: 0
DotNetBuildsInternalReadSasToken: $(dotnetbuilds-internal-container-read-token)
Expand Down
2 changes: 1 addition & 1 deletion eng/helix.proj
Expand Up @@ -21,7 +21,7 @@
<EnableAzurePipelinesReporter>false</EnableAzurePipelinesReporter>
<HelixSource>efcore/localbuild/</HelixSource>
<HelixBuild>t001</HelixBuild>
<MSSQL_SA_PASSWORD>Password12!</MSSQL_SA_PASSWORD>
<MSSQL_SA_PASSWORD>PLACEHOLDER</MSSQL_SA_PASSWORD>
</PropertyGroup>

<ItemGroup>
Expand Down