Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/translate json functions #29306 #30010
base: main
Are you sure you want to change the base?
Feature/translate json functions #29306 #30010
Changes from 12 commits
e3a58ca
8e4513e
d4e344b
d0055a4
058b875
5ff7e9f
92923bd
9fe9271
7310b30
fad6e0f
2b26705
2b0283b
afc2414
2b73ae7
87a58cc
a9e3a82
74aa115
80c7aa0
aa44131
3591505
39da9a7
7a0eede
1b2ff36
86760eb
f36540d
9ec4c33
50ee18e
e193c30
7e4815d
61afad4
320e2c4
d1a41e5
495abf0
3ac96dc
bd355ef
008a616
17a9035
0ff25bd
bf239e6
fe3d6c4
d990683
5d36a9b
ebac228
31662b3
aa5830f
7112c2b
4332623
16eea3d
db8e933
4313d6d
346cc35
1df1743
b66c286
b614e3e
e8d9247
00d51eb
d8e9f61
6a75f1d
eb449a2
1425f65
e0d5966
f8d153e
d4fd971
94bff5a
72b8d33
a0d6d06
d750109
cca2b4c
053dc5d
187b0b8
97a9c55
b776d0d
943e85b
d0cc35d
44b9763
5d2c758
0740f1c
e017dc1
ab4b617
4a33b7f
23d6a1d
f168170
60915e7
5be4798
338b76a
08ee676
fa442a2
fbb45f2
ebc6345
dfedecc
b06f376
18af811
e4ff864
9ea08b9
15413f5
684b1be
d7cd6f3
3b95d44
0c609ff
650e496
3eb3356
eadaa7f
b889ad1
c1faee1
255d58f
e6fb36c
bef191e
7c8127b
a60c399
fff995f
e3e7a5b
64ba990
0db7891
430da19
ac46968
ef76322
849b881
ad649c5
541aa86
32e4519
b540658
17aa7f7
45a8556
b354ebe
3af03d8
eb1d271
bbb0a35
4e63f03
79deed1
73ea00a
4d6a644
54e0df0
2be6f1d
5d1235a
f55b4a0
6980d92
1e32073
c818a11
47a995d
1727a68
f0e09e5
a635547
ccf749a
5488f27
47505c3
3d0512a
32e1d6f
1a7c80d
b848bf1
b385818
0386645
25ba437
e6291bf
141740f
1b59013
84505e3
c5262bb
aa97ce4
01a470c
c61a8c1
4567312
2f1c943
484a3ed
d79cd19
1f82d4d
d49e211
74cc719
b96c768
78214da
c040b11
caaf394
17fa62f
50a8ae5
3ebc2ca
6632487
98d7065
8743cd5
32c6133
cf5ec40
5533b74
f104409
e1594af
1048f6a
cfcdf56
9d84cf4
e84696d
e72bde5
e84e5ad
9d68988
679b311
5a4ffe6
db9846d
5d88b84
d1124fa
fd576b9
9af27b0
c57c334
7176495
06c2cae
22541af
aba897a
4f1cd17
a376787
f67d745
fb82304
a936d32
8c54538
bc81ee6
8e67582
5bceb5e
555421e
b01ea2f
8d78860
cb14437
e16a057
404fca5
9b0f169
209865e
a36839f
8e4dc09
85c16d5
fff96a3
02f1c43
2d7ed26
5defd88
040fe9a
651d5b9
e093b2c
b9a43a9
2e7ea62
566b241
414d9c3
c385d2b
7ea3a09
4d8ddea
1422e57
fc730cc
3f2b1fe
7ae58de
2c6fcb4
7f110e3
46ec69b
7376009
27c7bd0
d5a888c
cb2bbc8
02f9f37
571cc11
5b2ae4e
ee39973
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems a bit excessive to have a dictionary here for just one method, you can just have a single static property and compare to it directly below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason to add this rather than simply using JsonEntityBasic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JsonEntityBasic has mappings of the columns to classes, and this works only for strings If I understand it correctly.