This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Use overriden double/float GetHashCode for default struct hashcodes #16550
+56
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janvorli
reviewed
Feb 26, 2018
| void *pFieldValue = (BYTE *)pObj + field->GetOffsetUnsafe(); | ||
| if (field->IsObjRef()) | ||
| // if we get an object reference we get the hash code out of that | ||
| if (*(Object**)((BYTE *)pObjRef + field->GetOffsetUnsafe()) != NULL) |
There was a problem hiding this comment.
I wonder what was the reason for removing the pFieldValue and using the (BYTE *)pObjRef + field->GetOffsetUnsafe() at all places.
There was a problem hiding this comment.
I would have to add more GC protects for the pFieldValue. The original code tried to step around the GC protect, but it is not easy to do in the extra code that I have added (and I am also not sure whether the original got it 100% right).
janvorli
approved these changes
Feb 26, 2018
|
Thanks! I'm glad I don't have to replicate this bug on the CoreRT side :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16545