Adds an optional case sensitive property to most tokens, defaulting to true #2284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one way that #133 could be addressed. I am not 100% sure I hit all the test cases as I was adding them, but I hope I did. This PR would add an optional "caseSensitive" boolean to the constructors for most of the CliToken derivatives, defaulting to true. This would allow an application author to define the case sensitivity of their CLI tool at a granular level, which would hopefully support most use cases.
The downside to doing it this way is that it would (effectively) change some of the public API signatures (though most people's code should remain compatible without changes).