Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily skip Template.MVC tests on Helix #55696

Closed
wants to merge 2 commits into from
Closed

Temporarily skip Template.MVC tests on Helix #55696

wants to merge 2 commits into from

Conversation

captainsafia
Copy link
Member

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label May 13, 2024
@amcasey amcasey mentioned this pull request May 15, 2024
Merged
@amcasey
Copy link
Member

amcasey commented May 15, 2024

I can't help but notice that the CI failures are MVC helix tests. 😆

@wtgodbe
Copy link
Member

wtgodbe commented May 15, 2024

The failures are in Mvc.FunctionalTests - if it's the same root cause, we'd need to disable https://github.com/dotnet/aspnetcore/blob/main/src/Mvc/test/Mvc.FunctionalTests/Microsoft.AspNetCore.Mvc.FunctionalTests.csproj as well

@BrennanConroy BrennanConroy changed the title Temporarily skip MVC tests on Helix Temporarily skip Template.MVC tests on Helix May 15, 2024
@eerhardt
Copy link
Member

@captainsafia - is this still a change you want to make?

@captainsafia
Copy link
Member Author

Closing these. These tests don't run against the PR build so skipping them will provide little value WRT to helping with PR flow.

@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-preview5 milestone May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtgodbe wtgodbe wtgodbe approved these changes

Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Milestone
9.0-preview5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@captainsafia @amcasey @wtgodbe @eerhardt