Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarantine and attempt to fix CacheTagHelper_VaryByCultureComposesWithOtherVaryByOptions test #55369

Merged
merged 1 commit into from
Apr 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ void ReadValuesFromDocument()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/4907")]
public async Task CacheTagHelper_VaryByCultureComposesWithOtherVaryByOptions()
{
// Arrange
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@
<h2 id="culture">@CultureInfo.CurrentCulture</h2>
<h2 id="ui-culture">@CultureInfo.CurrentUICulture</h2>
<span id="correlation-id">@CorrelationId</span>
<test-cache vary-by-culture="true" vary-by-query="varyByQueryKey">
@*
Extend sliding expiration from it's default of 30 seconds to improve test reliability.
Anything over HttpClient's default timeout of 100 seconds should be sufficient.
https://github.com/dotnet/aspnetcore/issues/4907
*@
<test-cache vary-by-culture="true" vary-by-query="varyByQueryKey" expires-sliding="TimeSpan.FromSeconds(120)">
<span id="cached-correlation-id">@CorrelationId</span>
</test-cache>