-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UnixCertificateManager: implement IsTrusted. #55335
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,7 +18,12 @@ internal UnixCertificateManager(string subject, int version) | |
{ | ||
} | ||
|
||
public override bool IsTrusted(X509Certificate2 certificate) => false; | ||
public override bool IsTrusted(X509Certificate2 certificate) | ||
{ | ||
using X509Chain chain = new X509Chain(); | ||
chain.ChainPolicy.RevocationMode = X509RevocationMode.NoCheck; | ||
return chain.Build(certificate); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is there any reason not to use the logic on all platforms? It looks like on Windows we check for the cert in There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This checks the result rather than the implementation. It can be used on all platforms. |
||
} | ||
|
||
protected override X509Certificate2 SaveCertificateCore(X509Certificate2 certificate, StoreName storeName, StoreLocation storeLocation) | ||
{ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why disable revocation checking? Perf?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
X509Chain
usesOnline
as the default andSocketsHttpHandler
usesNoCheck
as the default.If we don't set this to
NoCheck
then verification fails because the local certificates have no online revocation list to check against.