Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow HTTP2 encoder to split headers across frames #55322

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Allow HTTP2 encoder to split headers across frames #55322

wants to merge 17 commits into from
+694 −321

Commits on May 22, 2024

  1. Initial implementation

    ladeak committed May 22, 2024
    Configuration menu
    Copy the full SHA
    a10d9ee View commit details
    Browse the repository at this point in the history

  2. Review feedback

    ladeak committed May 22, 2024
    Configuration menu
    Copy the full SHA
    5cad996 View commit details
    Browse the repository at this point in the history

  3. Updating a comment

    ladeak committed May 22, 2024
    Configuration menu
    Copy the full SHA
    f53dd7c View commit details
    Browse the repository at this point in the history

  4. Minor perf opt when all headers fit in a single header frame.

    ladeak committed May 22, 2024
    Configuration menu
    Copy the full SHA
    231c716 View commit details
    Browse the repository at this point in the history

  5. Adding MaxResponseHeadersLimit to H2 framewriter

    ladeak committed May 22, 2024
    Configuration menu
    Copy the full SHA
    887f505 View commit details
    Browse the repository at this point in the history

  6. Protect against overflow

    ladeak committed May 22, 2024
    Configuration menu
    Copy the full SHA
    b91a34c View commit details
    Browse the repository at this point in the history

  7. Validating the header length in HPackHeaderWriter

    ladeak committed May 22, 2024
    Configuration menu
    Copy the full SHA
    a655a38 View commit details
    Browse the repository at this point in the history

  8. Removing a test file commented out and adding more tests.

    ladeak committed May 22, 2024
    Configuration menu
    Copy the full SHA
    f31c8c8 View commit details
    Browse the repository at this point in the history

  9. Review feedback

    ladeak committed May 22, 2024
    Configuration menu
    Copy the full SHA
    6ab7271 View commit details
    Browse the repository at this point in the history

  10. Removing header limits related code because it is up to the service o… 

    …wner to not to ddos itself
    ladeak committed May 22, 2024
    Configuration menu
    Copy the full SHA
    e21620a View commit details
    Browse the repository at this point in the history

  11. A test for 1MB header value

    ladeak committed May 22, 2024
    Configuration menu
    Copy the full SHA
    9720c3a View commit details
    Browse the repository at this point in the history

  12. Review comments - removing an unneeded if condition

    ladeak committed May 22, 2024
    Configuration menu
    Copy the full SHA
    f8f8ff9 View commit details
    Browse the repository at this point in the history

  13. Sketch

    ladeak committed May 22, 2024
    Configuration menu
    Copy the full SHA
    994b27d View commit details
    Browse the repository at this point in the history

  14. using arraypool instead of arraybufferwriter

    ladeak committed May 22, 2024
    Configuration menu
    Copy the full SHA
    a77a930 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. Re-using the rented buffers

    ladeak committed May 24, 2024
    Configuration menu
    Copy the full SHA
    4f14b0c View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Preserving the size of the temporary larger buffer within the framewr… 

    …iter. This way if the same large header is written multiple times over the lifespan of a connection, it does not need to go through the loops of increasing the headers repetitively.
    ladeak committed May 30, 2024
    Configuration menu
    Copy the full SHA
    46be03f View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. Adjusting the logic of UpdateMaxFrameSize for setting a new _headersE… 

    …ncodingLargeBufferSize
    ladeak committed May 31, 2024
    Configuration menu
    Copy the full SHA
    9857dcb View commit details
    Browse the repository at this point in the history