Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding accept header to callsites within SignalR #55271

Merged
merged 47 commits into from
May 15, 2024
Merged

Adding accept header to callsites within SignalR #55271

merged 47 commits into from
May 15, 2024

Commits on Apr 18, 2024

  1. Adding accept header within NegotiateAsync() and default headers in C… 

    …reateHttpClient()
    @MattyLeslie
    MattyLeslie committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    9a06954 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. Removing defaultRequestHeader for accept and focusing on setting the … 

    …value on relevant call sites
    @MattyLeslie
    MattyLeslie committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    98f859f View commit details
    Browse the repository at this point in the history

  2. Removing the logic to clear accept headers before allocating the acce… 

    …pt header in NegotiateAsync()
    @MattyLeslie
    MattyLeslie committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    b4bebb5 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2024

  1. Adding accept header to LongPolling Get request within the Poll() method

    @MattyLeslie
    MattyLeslie committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    018350b View commit details
    Browse the repository at this point in the history

  2. Adding the accept header to SendUtils call site.

    @MattyLeslie
    MattyLeslie committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    a6fc3e5 View commit details
    Browse the repository at this point in the history

  3. Added the accept header to the LongPolling callsite for the inital po… 

    …lling request.
    @MattyLeslie
    MattyLeslie committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    6d793df View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. Merge branch 'dotnet:main' into SignalR--Missing-Accept-Header

    @MattyLeslie
    MattyLeslie committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    a56e8ed View commit details
    Browse the repository at this point in the history

  2. Removing whitespaces

    @MattyLeslie
    MattyLeslie committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    7576ac9 View commit details
    Browse the repository at this point in the history

  3. Removing comment and fixing whitespace

    @MattyLeslie
    MattyLeslie committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    168a108 View commit details
    Browse the repository at this point in the history

  4. Correcting indentations

    @MattyLeslie
    MattyLeslie committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    c3704ef View commit details
    Browse the repository at this point in the history

  5. retrigger checks

    @MattyLeslie
    MattyLeslie committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    e993ecc View commit details
    Browse the repository at this point in the history

  6. retrigger checks

    @MattyLeslie
    MattyLeslie committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    a00806a View commit details
    Browse the repository at this point in the history

  7. retrigger checks

    @MattyLeslie
    MattyLeslie committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    baea8dc View commit details
    Browse the repository at this point in the history

  8. Merge branch 'dotnet:main' into SignalR--Missing-Accept-Header

    @MattyLeslie
    MattyLeslie committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    d5e1948 View commit details
    Browse the repository at this point in the history

  9. retrigger checks

    @MattyLeslie
    MattyLeslie committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    335c09e View commit details
    Browse the repository at this point in the history

  10. Merge branch 'dotnet:main' into SignalR--Missing-Accept-Header

    @MattyLeslie
    MattyLeslie committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    ead6b97 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Removing default headers

    @MattyLeslie
    MattyLeslie committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    a0467c2 View commit details
    Browse the repository at this point in the history

  2. adding tests for LongPollingTransport to check accept headers are set… 

    … accoringly
    @MattyLeslie
    MattyLeslie committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    9c214bb View commit details
    Browse the repository at this point in the history

  3. Adding tests for ServerSentEventsTransport to check accept headers ar… 

    …e set accoringly
    @MattyLeslie
    MattyLeslie committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    feb1330 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'dotnet:main' into SignalR--Missing-Accept-Header

    @MattyLeslie
    MattyLeslie committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    fafbd9f View commit details
    Browse the repository at this point in the history

  5. Removing the Accept header addition for the SendDeleteRequestMethod()

    @MattyLeslie
    MattyLeslie committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    35614b7 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. HttpConnection tests for NegotiateAsync

    @MattyLeslie
    MattyLeslie committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    39ddeb3 View commit details
    Browse the repository at this point in the history

  2. Better method naming

    @MattyLeslie
    MattyLeslie committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    6c5dd09 View commit details
    Browse the repository at this point in the history

  3. Improving LongPollingTransportTests

    @MattyLeslie
    MattyLeslie committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    0204a27 View commit details
    Browse the repository at this point in the history

  4. Creating accept header tests for the SendUtils

    @MattyLeslie
    MattyLeslie committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    0b828ca View commit details
    Browse the repository at this point in the history

  5. Improving ServerSentEventTests for accept header

    @MattyLeslie
    MattyLeslie committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    69dae2a View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Adding an option parameter to HttpConnections contructor used for uni… 

    …t testing. Adding an optional HttpMessageHandler parameter for CreateHttpClient.
    @MattyLeslie
    MattyLeslie committed May 2, 2024
    Configuration menu
    Copy the full SHA
    bd2609f View commit details
    Browse the repository at this point in the history

  2. Addition of Test method to ensure NegotiateAsync() appends the correc… 

    …t header to the Http Request
    @MattyLeslie
    MattyLeslie committed May 2, 2024
    Configuration menu
    Copy the full SHA
    d570d08 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Removing changes related to injecting httpMessageHandler

    @MattyLeslie
    MattyLeslie committed May 3, 2024
    Configuration menu
    Copy the full SHA
    6f84149 View commit details
    Browse the repository at this point in the history

  2. Adjusting test to make use of httpmessageHandlerFactory and better pr… 

    …actices
    @MattyLeslie
    MattyLeslie committed May 3, 2024
    Configuration menu
    Copy the full SHA
    fe3a78a View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Updating implementation for NegotiateAsyncAppendsCorrectAcceptHeader

    @MattyLeslie
    MattyLeslie committed May 6, 2024
    Configuration menu
    Copy the full SHA
    50afbcb View commit details
    Browse the repository at this point in the history

  2. Uncommenting the addition of the accept header in NegotiateAsync()

    @MattyLeslie
    MattyLeslie committed May 6, 2024
    Configuration menu
    Copy the full SHA
    0aaf06f View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Final implementation for checking the correct header is appended to N… 

    …egotiateAsync
    @MattyLeslie
    MattyLeslie committed May 7, 2024
    Configuration menu
    Copy the full SHA
    14387c7 View commit details
    Browse the repository at this point in the history

  2. Ensuring the TaskCompletionSource is allocated to

    @MattyLeslie
    MattyLeslie committed May 7, 2024
    Configuration menu
    Copy the full SHA
    acbea26 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'dotnet:main' into SignalR--Missing-Accept-Header

    @MattyLeslie
    MattyLeslie committed May 7, 2024
    Configuration menu
    Copy the full SHA
    f6c6b14 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'SignalR--Missing-Accept-Header' of https://github.com/M… 

    …attyLeslie/aspnetcore into SignalR--Missing-Accept-Header
    @MattyLeslie
    MattyLeslie committed May 7, 2024
    Configuration menu
    Copy the full SHA
    824df9a View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Updating all TaskCompletionSources to run continuations asynchronously

    @MattyLeslie
    MattyLeslie committed May 10, 2024
    Configuration menu
    Copy the full SHA
    4c8c275 View commit details
    Browse the repository at this point in the history

  2. Sorting headers

    @MattyLeslie
    MattyLeslie committed May 10, 2024
    Configuration menu
    Copy the full SHA
    64b15b9 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. SendUtils test to use testHttpHandler instead of moq

    @MattyLeslie
    MattyLeslie committed May 14, 2024
    Configuration menu
    Copy the full SHA
    fb4d3e2 View commit details
    Browse the repository at this point in the history

  2. ServerSentEvents headers test to use testHttpHandler instead of moq

    @MattyLeslie
    MattyLeslie committed May 14, 2024
    Configuration menu
    Copy the full SHA
    a226948 View commit details
    Browse the repository at this point in the history

  3. Improvement to PollRequestsContainCorrectAcceptHeader method to effec… 

    …tively handle the intial http request and the requests in Poll()
    @MattyLeslie
    MattyLeslie committed May 14, 2024
    Configuration menu
    Copy the full SHA
    1a5a21e View commit details
    Browse the repository at this point in the history

  4. Merge branch 'dotnet:main' into SignalR--Missing-Accept-Header

    @MattyLeslie
    MattyLeslie committed May 14, 2024
    Configuration menu
    Copy the full SHA
    72b609a View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Adding default timeouts

    @MattyLeslie
    MattyLeslie committed May 15, 2024
    Configuration menu
    Copy the full SHA
    d4e3f0c View commit details
    Browse the repository at this point in the history

  2. Sorting using statements and removing Moq

    @MattyLeslie
    MattyLeslie committed May 15, 2024
    Configuration menu
    Copy the full SHA
    8df74b9 View commit details
    Browse the repository at this point in the history

  3. Removing delay, only using secondRequestReceived, adding default time… 

    …outs and using testUri
    @MattyLeslie
    MattyLeslie committed May 15, 2024
    Configuration menu
    Copy the full SHA
    bf623c0 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'SignalR--Missing-Accept-Header' of https://github.com/M… 

    …attyLeslie/aspnetcore into SignalR--Missing-Accept-Header
    @MattyLeslie
    MattyLeslie committed May 15, 2024
    Configuration menu
    Copy the full SHA
    f359abf View commit details
    Browse the repository at this point in the history

  5. Adding default time to CompletionSource

    @MattyLeslie
    MattyLeslie committed May 15, 2024
    Configuration menu
    Copy the full SHA
    fe978ae View commit details
    Browse the repository at this point in the history