Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALWAYS include the Vary Accept-Encoding header when response compression is enabled #55092

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ALWAYS include the Vary Accept-Encoding header when response compression is enabled #55092

wants to merge 2 commits into from
+12 −14

Conversation

pedrobsaila
Copy link

ALWAYS include the Vary Accept-Encoding header when response compression is enabled

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Description

ALWAYS include the Vary Accept-Encoding header when response compression is enabled

Fixes #48008

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlesware label Apr 11, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Apr 11, 2024
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Apr 22, 2024
@pedrobsaila pedrobsaila reopened this May 14, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-preview5 milestone May 14, 2024
@adityamandaleeka
Copy link
Member

@pedrobsaila Sorry for the longer-than-usual delay for getting things reviewed. This is still on our radar.

@pedrobsaila
Copy link
Author

Sorry for the longer-than-usual delay for getting things reviewed. This is still on our radar.

no worries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@adityamandaleeka adityamandaleeka

Labels
area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlesware community-contribution Indicates that the PR has been added by a community member pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun
Projects
None yet
Milestone
9.0-preview5
Development

Successfully merging this pull request may close these issues.

ALWAYS include the Vary: Accept-Encoding header when response compression is enabled
2 participants
@pedrobsaila @adityamandaleeka