Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#54445 ChecksumValidator: Support checksum SHA256 even when the metadata uses Sha256 #54446

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

yepeekai
Copy link
Contributor

@yepeekai yepeekai commented Mar 8, 2024

Support RazorViewChecksum Sha256. Dotnet 8 and/or visual studio now use Sha256 instead of SHA256. Adjustments to ignore case when comparing algorithm names.

Fixes #54445

related to #45577

@yepeekai yepeekai requested a review from a team as a code owner March 8, 2024 19:08
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Mar 8, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Mar 8, 2024
@yepeekai
Copy link
Contributor Author

yepeekai commented Mar 8, 2024

@dotnet-policy-service agree

@mkArtakMSFT mkArtakMSFT added area-ui-rendering Includes: MVC Views/Pages, Razor Views/Pages and removed area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels Mar 8, 2024
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Mar 16, 2024
@yepeekai
Copy link
Contributor Author

/azp run

Copy link

Commenter does not have sufficient privileges for PR 54446 in repo dotnet/aspnetcore

@captainsafia
Copy link
Member

/azp run

@dotnet-policy-service dotnet-policy-service bot removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Mar 18, 2024
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@captainsafia captainsafia removed the request for review from a team March 18, 2024 15:45
Copy link
Contributor

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Mar 26, 2024
github-actions bot and others added 2 commits April 8, 2024 12:15
Update .NET SDK to version 9.0.100-preview.4.24207.7.

---
updated-dependencies:
- dependency-name: Microsoft.NET.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
….4.24207.7

Update .NET SDK to 9.0.100-preview.4.24207.7
@yepeekai yepeekai requested review from wtgodbe and a team as code owners April 9, 2024 11:37
github-actions bot and others added 4 commits April 15, 2024 12:17
Update .NET SDK to version 9.0.100-preview.4.24215.2.

---
updated-dependencies:
- dependency-name: Microsoft.NET.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
….4.24215.2

Update .NET SDK to 9.0.100-preview.4.24215.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-ui-rendering Includes: MVC Views/Pages, Razor Views/Pages community-contribution Indicates that the PR has been added by a community member pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AddRazorRuntimeCompilation do not work with .net8 or recent version of visual studio
4 participants