Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for hosting extensions #1653

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

YAJeff
Copy link
Contributor

@YAJeff YAJeff commented Jan 21, 2023

With this change, the MQTTnet server can be hosted using Microsoft.Extensions.Hosting library, rather than full ASP.net core SDK.

@@ -0,0 +1,19 @@
<Project Sdk="Microsoft.NET.Sdk">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion we should call this project "MQTTnet.Extensions.Hosting" to fit the other extensions (The Asp library was introduced before the naming pattern was established).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YAJeff Ping?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Sorry. I have made those changes internally. Sorry. Been traveling for work. Will check in. There were other changes I've added to make things a little more solid/sound. Will have completed by the end of the weekend.

Samples/MQTTnet.Samples.csproj Outdated Show resolved Hide resolved
@chkr1011
Copy link
Collaborator

@YAJeff Please agree to the Contributor License. Then I will merge this PR.

@kallayj
Copy link
Contributor

kallayj commented Oct 26, 2023

@dotnet-policy-service agree company="CARIAD Inc"

@kallayj
Copy link
Contributor

kallayj commented Oct 26, 2023

@chkr1011 I've merged the latest from main into @YAJeff's fork and agreed to the CLA on behalf of the company we both work for.

@chkr1011
Copy link
Collaborator

chkr1011 commented Nov 4, 2023

@kallayj This does not seem to work. The agreement is still in "Contributor License Agreement is not agreed yet." state. I am afraid you have to create a new PR on your own (or please @YAJeff) to accept it.

@YAJeff
Copy link
Contributor Author

YAJeff commented Nov 6, 2023

@dotnet-policy-service agree company="CARIAD Inc"

@kallayj
Copy link
Contributor

kallayj commented Nov 8, 2023

@chkr1011 the CLA check has passed, can this move forward?

@chkr1011
Copy link
Collaborator

@kallayj I applied the code style and moved the tests a little around to get the code compiling.

There are still some warnings left and some new properties are not even used. Please let me know when the code is finished so that I can review it.

@kallayj
Copy link
Contributor

kallayj commented Nov 20, 2023

@chkr1011 I addressed the nullable reference type warnings. Where are you seeing unused properties?

@chkr1011
Copy link
Collaborator

Please see "MqttServerHostingOptions.WebSocketRoute". It is set but never read. Same for "WebSocketAuthenticationCallback".

@kallayj
Copy link
Contributor

kallayj commented Nov 29, 2023

@chkr1011 I removed those properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants