Fix anal noise #4630
Open
Fix anal noise #4630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(mostly CA1050 136, IDE0290 134)
| @@ -87,12 +87,9 @@ public class BooksContext : DbContext | |||
| { | |||
| public DbSet<User> Users { get; set; } | |||
|
|
|||
| private readonly bool _quiet; | |||
There was a problem hiding this comment.
Many changes make things more explicit, but this one goes in the opposite direction and makes it implicit. Could you tell me what's the reason for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to address Issue #4612
.editorconfig left unchanged although temporarily edited to "dotnet_style_namespace_match_folder = false"
as many project use NS to distinguish local DbContext scopes)
HTH modernise EF Docs !
BTW I have mostly ignored the CompiledModels, but may raise further Issue + PR if I get time.