Windows: Connect -> ConnectionLost -> Reconnect #849

AskBojesen · 2024-05-08T15:02:29Z

To fix: #826

demolog.txt

janusw · 2024-05-10T12:12:30Z

To fix: #826

@CodeMusher Does this fix the problem for you?

CodeMusher · 2024-05-10T17:50:35Z

@janusw I’ll try to check that tomorrow!

CodeMusher · 2024-05-11T15:28:39Z

@janusw @AskBojesen
Now I've tried to test the solution and it works much better now.

For some reason the line below in the Adapter.cs for Windows throws System.InvalidCastException
var conpar = nativeDevice.GetConnectionParameters();
It gives me the following StackTrace
at WinRT.IObjectReference.As[T](Guid iid)
at Windows.Devices.Bluetooth.BluetoothLEDevice.Make___objRef_global__Windows_Devices_Bluetooth_IBluetoothLEDevice6()
at Windows.Devices.Bluetooth.BluetoothLEDevice.get__objRef_global__Windows_Devices_Bluetooth_IBluetoothLEDevice6()
at Windows.Devices.Bluetooth.BluetoothLEDevice.GetConnectionParameters()
at Plugin.BLE.Windows.Adapter.Device_ConnectionStatusChanged(BluetoothLEDevice nativeDevice, Object args) in C:\git\GitHub\dotnet-bluetooth-le\Source\Plugin.BLE\Windows\Adapter.cs:line 139
at WinRT.EventSource_global__Windows_Foundation_TypedEventHandler_global__Windows_Devices_Bluetooth_BluetoothLEDevice__object.EventState.b__1_0(BluetoothLEDevice sender, Object args)
at ABI.Windows.Foundation.TypedEventHandler`2.Do_Abi_Invoke[TSenderAbi,TResultAbi](Void* thisPtr, TSenderAbi sender, TResultAbi args)
I needed to catch that exception to be able to continue. Strange, I don't think that thing isn't changed recently

axa88 · 2024-05-11T16:41:26Z

~~I dont use the console demo or any other abstraction over the base library so perhaps my feedback isnt useful here, but...~~

Ive tested this pull and the problem i see with it is after the first Connect/Disconnect cycle, a subscription to either the Adapter.DeviceConnected and Adapater.DeviceDisconnected events will be lost.
Meaning while subsequent calls to Connect will connect, and subsequent calls to Disconnect will disconnect, subscription to their associated events are no longer called subsequently.

What can i say, it works now... i think VS has a bug in applying these nugets with similar version numbers... but what do i know...

CodeMusher · 2024-05-11T18:59:14Z

@axa88 I’ve not tested in the real application either, but if it is like you are describing it regarding the events then it’s not good.

CodeMusher · 2024-05-12T15:18:00Z

Now I've tried the PR a step up in the abstraction chain, that is my test application. It seems like I get both Adapter.DeviceConnected and Adapter.DeviceConnectionLost when I power cycle my peripheral. In my setup it seems to work!

…econnect

AskBojesen · 2024-05-13T07:57:28Z

@janusw @AskBojesen Now I've tried to test the solution and it works much better now.

For some reason the line below in the Adapter.cs for Windows throws System.InvalidCastException var conpar = nativeDevice.GetConnectionParameters(); It gives me the following StackTrace at WinRT.IObjectReference.As[T](Guid iid) at Windows.Devices.Bluetooth.BluetoothLEDevice.Make___objRef_global__Windows_Devices_Bluetooth_IBluetoothLEDevice6() at Windows.Devices.Bluetooth.BluetoothLEDevice.get__objRef_global__Windows_Devices_Bluetooth_IBluetoothLEDevice6() at Windows.Devices.Bluetooth.BluetoothLEDevice.GetConnectionParameters() at Plugin.BLE.Windows.Adapter.Device_ConnectionStatusChanged(BluetoothLEDevice nativeDevice, Object args) in C:\git\GitHub\dotnet-bluetooth-le\Source\Plugin.BLE\Windows\Adapter.cs:line 139 at WinRT.EventSource_global__Windows_Foundation_TypedEventHandler_global__Windows_Devices_Bluetooth_BluetoothLEDevice__object.EventState.b__1_0(BluetoothLEDevice sender, Object args) at ABI.Windows.Foundation.TypedEventHandler`2.Do_Abi_Invoke[TSenderAbi,TResultAbi](Void* thisPtr, TSenderAbi sender, TResultAbi args) I needed to catch that exception to be able to continue. Strange, I don't think that thing isn't changed recently

The code has been in there for a while - but it is new to 3.1 vs 3.0.

It is bad if an exception is thrown for the GetConnectionParameters(), because then the HandleConnectedDevice(connectedDevice) is not called (see below image)
@CodeMusher : Is it everytime you get this exception?
We could make a try'n'catch in the code when calling GetConnectionParameters, so the logic is still working

janusw · 2024-05-13T16:12:26Z

For some reason the line below in the Adapter.cs for Windows throws System.InvalidCastException
var conpar = nativeDevice.GetConnectionParameters();

Huh, that line as such looks rather innocent, and I don't really see why it would generate an InvalidCastException.

However BluetoothLEDevice.GetConnectionParameters is only available in Windows 11 (build 10.0.22000.0) and is guarded by a corresponding compile-time check. But I suspect we're missing a proper runtime API version check.

@CodeMusher Two questions:

Which Windows version are you targeting in your application?
Which Windows version are you actually running it on?

CodeMusher · 2024-05-13T17:08:19Z

@janusw You're right that it must be the runtime that messes it up

Which Windows version are you targeting in your application?
I target net8.0-windows10.0.22621.0 as that is what the WinConsole sample is using
Which Windows version are you actually running it on?
My laptop only runs 10.0.19045 so that must be what causing the problem.

CodeMusher · 2024-05-13T17:21:28Z

The tests I performed yesterday were power cycling the peripheral. These tests gave me
Adapter.DeviceConnected
Adapter.DeviceConnectionLost.

Today I tried to initiate disconnect from the app instead. I thought that would invoke a Adapter.DeviceDisconnected.
But it always invokes Adapter.DeviceConnectionLost.
Is that really what I should expect?

AskBojesen · 2024-05-13T17:44:25Z

@janusw You're right that it must be the runtime that messes it up

Which Windows version are you targeting in your application?
I target net8.0-windows10.0.22621.0 as that is what the WinConsole sample is using

Which Windows version are you actually running it on?
My laptop only runs 10.0.19045 so that must be what causing the problem.

you need runtime check if running on Windows 10, or you must use another target than 10.0.22621
Unfortunately Windows has no check for runtime - you simply get exceptions has you saw!

I have made a runtime check as custom action for the installer for our desktop app to avoid running on eg. 10.0.19045

public static int CurrentBuild()
{
    var reg = Registry.LocalMachine.OpenSubKey(@"SOFTWARE\Microsoft\Windows NT\CurrentVersion");
    var currentBuildStr = (string)reg.GetValue("CurrentBuild");
    var currentBuild = int.Parse(currentBuildStr);
    return currentBuild;
}

public override void Install(IDictionary stateSaver)
{
    // Environment.OSVersion.Version.Build does not work on .Net framework
    //int currentBuild = Environment.OSVersion.Version.Build;
    int currentBuild = CurrentBuild();
    LogText($"CurrentBuild = {currentBuild}");
    if (currentBuild < 22000)
    {
        StringBuilder sb = new StringBuilder();
        sb.AppendLine("ILab can only run on Windows 11 and higher")
                  .AppendLine()
                  .AppendLine($"CurrentBuild is {currentBuild}, which must be higher or equal to 22000");
        throw new NotSupportedException(sb.ToString());
    }
    base.Install(stateSaver);
}

AskBojesen · 2024-05-13T17:49:17Z

@CodeMusher : I get Adapter.DeviceDisconnected when testing with the winconsole client...

You Write: Disconnecting from app - which app on which platform?

See the first lines in the attached demolog.txt

Running: Connect -> Disconnect

18.10.11.085       DEMO - Disconnecting
18.10.11.085 Plugin.BLE - DisconnectDeviceNative from device with ID:  8C4B14C9C43A
18.10.14.191 Plugin.BLE - Device_ConnectionStatusChanged 8C4B14C9C43A Egoo RD123456 Disconnected
18.10.14.191 Plugin.BLE - DisconnectedPeripheral by user: Egoo RD123456
18.10.14.191       DEMO - Adapter_DeviceDisconnected 8C4B14C9C43A with name: Egoo RD123456
18.10.14.191 Plugin.BLE - DisconnectAsync Disconnected: 00000000-0000-0000-0000-8c4b14c9c43a Egoo RD123456
18.10.14.191       DEMO - Test_Connect_Disconnect done

CodeMusher · 2024-05-13T19:25:15Z

@AskBojesen > you need runtime check if running on Windows 10, or you must use another target than 10.0.22621 Unfortunately Windows has no check for runtime - you simply get exceptions has you saw!

I have made a runtime check as custom action for the installer for our desktop app to avoid running on eg. 10.0.19045

Ok, I'll keep that in mind, missed that one.

janusw · 2024-05-13T19:33:51Z

@janusw You're right that it must be the runtime that messes it up

Which Windows version are you targeting in your application?
I target net8.0-windows10.0.22621.0 as that is what the WinConsole sample is using

Which Windows version are you actually running it on?
My laptop only runs 10.0.19045 so that must be what causing the problem.

Thanks for the info. This indeed confirms my suspicion.

you need runtime check if running on Windows 10, or you must use another target than 10.0.22621 Unfortunately Windows has no check for runtime - you simply get exceptions has you saw!

Well, I think the library should better guard the version-dependent code by a runtime check and only execute it if it's supported (see https://learn.microsoft.com/en-us/windows/uwp/debug-test-perf/version-adaptive-apps).

For BluetoothLEDevice.GetConnection one needs to check for UniversalApiContract v14 AFAICS.

CodeMusher · 2024-05-13T19:34:57Z

@AskBojesen > Disconnecting from app - which app on which platform?

It is my test app running on top of your library on Windows. I've checked the old code and it seems like it does something else than how it is done in the WinConsole.
So I believe the issue is on my side this time.

AskBojesen · 2024-05-13T19:42:47Z

@janusw You're right that it must be the runtime that messes it up

Which Windows version are you targeting in your application?
I target net8.0-windows10.0.22621.0 as that is what the WinConsole sample is using

Which Windows version are you actually running it on?
My laptop only runs 10.0.19045 so that must be what causing the problem.

Thanks for the info. This indeed confirms my suspicion.

you need runtime check if running on Windows 10, or you must use another target than 10.0.22621 Unfortunately Windows has no check for runtime - you simply get exceptions has you saw!

Well, I think the library should better guard the version-dependent code by a runtime check and only execute it if it's supported (see https://learn.microsoft.com/en-us/windows/uwp/debug-test-perf/version-adaptive-apps).

For BluetoothLEDevice.GetConnection one needs to check for UniversalApiContract v14 AFAICS.

I agree - that it is dangerous as it is now - I got a nasty surprise myself trying to run the desktop app on Windows 10.
But @janusw : Can we keep focus on this PR for the original connection lost issue - and create another PR for Windows Runtime awareness ?

AskBojesen · 2024-05-14T19:36:31Z

@CodeMusher , @axa88 : Can you please confirm, that the original issue for this PR is solved?

Original issue: not connection lost of lost without client request

AskBojesen · 2024-05-14T19:39:13Z

Note: open issues not fixed in this PR:

When this PR is approved and merged, then I will look into the three issues above.

axa88 · 2024-05-14T20:20:46Z

@CodeMusher , @axa88 : Can you please confirm, that the original issue for this PR is solved?

Original issue: not connection lost of lost without client request

@AskBojesen
Im unable to confirm anything regarding this issue. With this build it doesn't take much more than 2 connect/disconnect cycles before my device is left in an unusable state which will no longer connect/disconnect as reported elsewhere.

I can report the first connect/disconnect/lost cycle does appear to work, just not anything further.

CodeMusher · 2024-05-15T15:52:12Z

I believe my initial issue is solved by this.

…

14 maj 2024 kl. 22:21 skrev axa88 ***@***.***>: @CodeMusher , @axa88 : Can you please confirm, that the original issue for this PR is solved? Original issue: not connection lost of lost without client request @AskBojesen Im unable to confirm anything regarding this issue. With this build it doesn't take much more than 2 connect/disconnect cycles before my device is left in an unusable state which will no longer connect/disconnect as reported elsewhere. I can report the first connect/disconnect/lost cycle does appear to work. But just not anything past that. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

janusw

I believe my initial issue is solved by this.

Alright, then let's merge it. The modification of the library itself is rather simple, after all, and ok with me.

axa88 · 2024-05-17T08:34:57Z

Note: open issues not fixed in this PR:

* [Windows: Check OS version runtime #852](https://github.com/dotnet-bluetooth-le/dotnet-bluetooth-le/issues/852)

* [WinUI Call to `DisconnectDeviceAsync` may not complete. #850](https://github.com/dotnet-bluetooth-le/dotnet-bluetooth-le/issues/850)

* [Disconnect hangs sometimes on Windows #788](https://github.com/dotnet-bluetooth-le/dotnet-bluetooth-le/issues/788)

When this PR is approved and merged, then I will look into the three issues above.

Perhaps consider closing #717 as well, arguably qualifies to be closed already but surely after you address the above...
you might take a look at #619 as well.

Improved demo for Connect_ConnectionLost_Reconnect

e7ebdbf

AskBojesen mentioned this pull request May 8, 2024

Windows: More than one lost connection does not work correctly #826

Closed

AskBojesen marked this pull request as draft May 8, 2024 15:14

AskBojesen changed the title ~~Windows: Improve demo for Connect_ConnectionLost_Reconnect~~ Windows: Connect_ConnectionLost_Reconnect May 8, 2024

AskBojesen changed the title ~~Windows: Connect_ConnectionLost_Reconnect~~ Windows: Connect -> ConnectionLost -> Reconnect May 8, 2024

AskBojesen added 2 commits May 8, 2024 17:59

Fixed connection lost

a54b536

Fixed comment in code

a9efc5a

AskBojesen marked this pull request as ready for review May 8, 2024 16:15

janusw added the os:Windows label May 8, 2024

axa88 mentioned this pull request May 11, 2024

[WinUI] [3.1.0-beta.1] introduces null IDevice(s) to device lists #828

Closed

Merge branch 'dotnet-bluetooth-le:master' into demo_connection_lost_r…

ee64c6c

…econnect

janusw approved these changes May 15, 2024

View reviewed changes

janusw merged commit c894e46 into dotnet-bluetooth-le:master May 15, 2024
3 checks passed

janusw mentioned this pull request May 15, 2024

Windows: Check OS version runtime #852

Closed

AskBojesen deleted the demo_connection_lost_reconnect branch May 16, 2024 07:09

janusw mentioned this pull request May 16, 2024

Windows: Check for OS build number version Runtime #853

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Windows: Connect -> ConnectionLost -> Reconnect #849

Windows: Connect -> ConnectionLost -> Reconnect #849

AskBojesen commented May 8, 2024 •

edited

janusw commented May 10, 2024

CodeMusher commented May 10, 2024

CodeMusher commented May 11, 2024

axa88 commented May 11, 2024 •

edited

CodeMusher commented May 11, 2024

CodeMusher commented May 12, 2024

AskBojesen commented May 13, 2024 •

edited

janusw commented May 13, 2024 •

edited

CodeMusher commented May 13, 2024

CodeMusher commented May 13, 2024

AskBojesen commented May 13, 2024 •

edited

AskBojesen commented May 13, 2024 •

edited

CodeMusher commented May 13, 2024

janusw commented May 13, 2024

CodeMusher commented May 13, 2024

AskBojesen commented May 13, 2024

AskBojesen commented May 14, 2024

AskBojesen commented May 14, 2024 •

edited

axa88 commented May 14, 2024 •

edited

CodeMusher commented May 15, 2024 via email

janusw left a comment

axa88 commented May 17, 2024 •

edited

Windows: Connect -> ConnectionLost -> Reconnect #849

Windows: Connect -> ConnectionLost -> Reconnect #849

Conversation

AskBojesen commented May 8, 2024 • edited

janusw commented May 10, 2024

CodeMusher commented May 10, 2024

CodeMusher commented May 11, 2024

axa88 commented May 11, 2024 • edited

CodeMusher commented May 11, 2024

CodeMusher commented May 12, 2024

AskBojesen commented May 13, 2024 • edited

janusw commented May 13, 2024 • edited

CodeMusher commented May 13, 2024

CodeMusher commented May 13, 2024

AskBojesen commented May 13, 2024 • edited

AskBojesen commented May 13, 2024 • edited

CodeMusher commented May 13, 2024

janusw commented May 13, 2024

CodeMusher commented May 13, 2024

AskBojesen commented May 13, 2024

AskBojesen commented May 14, 2024

AskBojesen commented May 14, 2024 • edited

axa88 commented May 14, 2024 • edited

CodeMusher commented May 15, 2024 via email

janusw left a comment

Choose a reason for hiding this comment

axa88 commented May 17, 2024 • edited

AskBojesen commented May 8, 2024 •

edited

axa88 commented May 11, 2024 •

edited

AskBojesen commented May 13, 2024 •

edited

janusw commented May 13, 2024 •

edited

AskBojesen commented May 13, 2024 •

edited

AskBojesen commented May 13, 2024 •

edited

AskBojesen commented May 14, 2024 •

edited

axa88 commented May 14, 2024 •

edited

axa88 commented May 17, 2024 •

edited