Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Adapter.SupportsExtendedAdvertising on Windows #845

Merged
merged 1 commit into from May 11, 2024

Conversation

janusw
Copy link
Member

@janusw janusw commented May 5, 2024

see the discussion in #815

@janusw janusw changed the title implement Adapter.SupportsExtendedAdvertising on Windows Implement Adapter.SupportsExtendedAdvertising on Windows May 5, 2024
@janusw
Copy link
Member Author

janusw commented May 8, 2024

@axa88 Could you check if this works well for you? (Testing on Windows is not fully impossible but rather effortful for me). There is a nupkg built by GHA which you can use for testing.

@axa88
Copy link

axa88 commented May 9, 2024

@axa88 Could you check if this works well for you? (Testing on Windows is not fully impossible but rather effortful for me). There is a nupkg built by GHA which you can use for testing.

Im not entirely sure of what i need to confirm proper functionality.
But i do know i do not have Windows hardware that supports extended advertising...

@janusw
Copy link
Member Author

janusw commented May 9, 2024

@axa88 Could you check if this works well for you? (Testing on Windows is not fully impossible but rather effortful for me). There is a nupkg built by GHA which you can use for testing.

Im not entirely sure of what i need to confirm proper functionality. But i do know i do not have Windows hardware that supports extended advertising...

Well, in that case it would be enough if you could simply confirm that SupportsExtendedAdvertising still returns false, as before (and there are no exceptions or errors).

I'll check if I have some Windows hardware that supports extended advertising.

@axa88
Copy link

axa88 commented May 10, 2024

Well, in that case it would be enough if you could simply confirm that SupportsExtendedAdvertising still returns false, as before (and there are no exceptions or errors).

Things continue to work as they did..

@janusw
Copy link
Member Author

janusw commented May 11, 2024

Well, in that case it would be enough if you could simply confirm that SupportsExtendedAdvertising still returns false, as before (and there are no exceptions or errors).

Things continue to work as they did..

Thanks for the confirmation. I also managed to test this by now, but my Windows test device also returns false (an oldish Dell XPS 13 notebook). In any case this is enough to verify that the native API call works correctly, so I will merge this simple PR.

@janusw janusw merged commit a5f8e6c into dotnet-bluetooth-le:master May 11, 2024
3 checks passed
@janusw janusw deleted the win_ext_adv_supported branch May 11, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants