Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(edit-page-2): Experiments had dirty state when navigating to a variant #28569

Merged
merged 4 commits into from
May 15, 2024

Conversation

zJaaal
Copy link
Contributor

@zJaaal zJaaal commented May 14, 2024

Proposed Changes

  • Add new property to the state to indicate a reload in the iframe
  • Activate inline editing for variants, which was disabled due to logic error

Screenshots

Screen.Recording.2024-05-14.at.5.38.28.PM.mov

@zJaaal
Copy link
Contributor Author

zJaaal commented May 15, 2024

Note to QA

Be sure that the Editor fully works with variants and it shows the updated data after navigating to a variant.

@zJaaal zJaaal marked this pull request as ready for review May 15, 2024 13:19
@fmontes fmontes changed the title fix(edit-page-v2): Experiments had dirty state when navigating to a variant fix(edit-page-2): Experiments had dirty state when navigating to a variant May 15, 2024
@fmontes fmontes added this pull request to the merge queue May 15, 2024
Merged via the queue into master with commit e714470 May 15, 2024
15 checks passed
@fmontes fmontes deleted the experiments-dirty-state-uve branch May 15, 2024 15:40
@rjvelazco
Copy link
Contributor

Passed Internal QA

  • Tested on Docker image: [dotcms:trunk_ 63a26cc]

Video

experiments-dirty-state-uve.mov

@zJaaal
Copy link
Contributor Author

zJaaal commented May 20, 2024

Note to QA

Issue

The issue was that every time we navigated to edit a variant from experiments in the UVE, we ended editing the original page instead of the variant.

Steps to Reproduce

  1. Be sure that the UVE and Experiments can be used.
  2. Go to the UVE for VTLs pages using any page.
  3. Make recognizable changes in the page so you can know which is the original page.
  4. Wait for the page to save
  5. Go to experiments and create a new experiement
  6. Create a Variant
  7. Press edit button in the variants to edit that variant in the UVE
  8. See that the page is a clone from the original, make changes so you can know this is the variant.
  9. Wait for the page to save
  10. Go back to experiments and select the recently created experiment
  11. Press the edit button again to go edit the variant
  12. You should see the Variant and not the Original Page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: QA - In Progress
Development

Successfully merging this pull request may close these issues.

None yet

4 participants