-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(edit-page-2): Experiments had dirty state when navigating to a variant #28569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zJaaal
requested review from
fmontes,
oidacra,
hmoreras,
rjvelazco and
KevinDavilaDotCMS
May 14, 2024 20:42
zJaaal
added
Team : Lunik
OKR : Technical User Experience
Owned by Freddy
Priority : 2 High
labels
May 14, 2024
oidacra
approved these changes
May 15, 2024
Note to QABe sure that the Editor fully works with variants and it shows the updated data after navigating to a variant. |
Quality Gate passedIssues Measures |
rjvelazco
approved these changes
May 15, 2024
fmontes
changed the title
fix(edit-page-v2): Experiments had dirty state when navigating to a variant
fix(edit-page-2): Experiments had dirty state when navigating to a variant
May 15, 2024
Passed Internal QA
Videoexperiments-dirty-state-uve.mov |
Note to QAIssueThe issue was that every time we navigated to edit a variant from experiments in the UVE, we ended editing the original page instead of the variant. Steps to Reproduce
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Screenshots
Screen.Recording.2024-05-14.at.5.38.28.PM.mov