Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#28059 Postman test enhancements #28515

Merged
merged 6 commits into from
May 15, 2024
Merged

Conversation

bryanboza
Copy link
Member

@bryanboza bryanboza commented May 9, 2024

Proposed Changes

  • Changes in the postman test for the Site_Resource

Checklist

  • Tests

Additional Info

Implement auth based on token

Screenshots

Original Updated
** original screenshot ** ** updated screenshot **

@jgambarios jgambarios added this pull request to the merge queue May 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 10, 2024
@nollymar nollymar added this pull request to the merge queue May 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 10, 2024
@bryanboza bryanboza added this pull request to the merge queue May 13, 2024
@bryanboza bryanboza removed this pull request from the merge queue due to a manual request May 13, 2024
@bryanboza bryanboza enabled auto-merge May 13, 2024 21:35
@bryanboza bryanboza added this pull request to the merge queue May 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 13, 2024
Copy link
Contributor

@spbolton spbolton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you could modify .github/filters.yaml and add an entry for - 'dotcms-postman/**' above the similar entry for dotcms-integration it should make sure that your PR causes the postman tests to actually run in the PR build so issues are found before being added to the merge queue. Theoretically we could split out the flags so it does not run the integration tests, but it does not really add more time to the build as they are run in parallel, just would save resources.

Thanks.

@bryanboza bryanboza requested a review from a team as a code owner May 14, 2024 18:52
@bryanboza
Copy link
Member Author

If you could modify .github/filters.yaml and add an entry for - 'dotcms-postman/**' above the similar entry for dotcms-integration it should make sure that your PR causes the postman tests to actually run in the PR build so issues are found before being added to the merge queue. Theoretically we could split out the flags so it does not run the integration tests, but it does not really add more time to the build as they are run in parallel, just would save resources.

Thanks.

Done

@bryanboza bryanboza requested a review from spbolton May 14, 2024 18:56
Signed-off-by: bryanboza <bryan.bozacastillo@dotcms.com>
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@bryanboza bryanboza enabled auto-merge May 14, 2024 22:02
@bryanboza bryanboza added this pull request to the merge queue May 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 15, 2024
@bryanboza bryanboza added this pull request to the merge queue May 15, 2024
Merged via the queue into master with commit 2358a97 May 15, 2024
26 checks passed
@bryanboza bryanboza deleted the postman-improvements-issue#28059 branch May 15, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

4 participants