Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular SDK: 👷🏽‍♂️ Render dotCMS pages using @dotcms/client #28506

Merged

Conversation

rjvelazco
Copy link
Contributor

@rjvelazco rjvelazco commented May 9, 2024

Angular Example

issue-28497-angular-sdk-render-dotcms-pages-using-dotcmsclient-1.mov

@rjvelazco rjvelazco self-assigned this May 9, 2024
@rjvelazco rjvelazco linked an issue May 9, 2024 that may be closed by this pull request
9 tasks
@rjvelazco rjvelazco marked this pull request as ready for review May 14, 2024 17:04
@rjvelazco
Copy link
Contributor Author

@dotCMS/frontend you can ignore everything related to the library. It will be better worked here: #28498

@fmontes
Copy link
Member

fmontes commented May 15, 2024

@rjvelazco Love the video! can we add a "container" class in the main section so we can have a max width

Copy link
Member

@fmontes fmontes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with the option of change

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@rjvelazco rjvelazco added this pull request to the merge queue May 15, 2024
Merged via the queue into master with commit 0ba9739 May 15, 2024
14 checks passed
@rjvelazco rjvelazco deleted the issue-28497-angular-sdk-render-dotcms-pages-using-dotcmsclient branch May 15, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Angular SDK: 👷🏽‍♂️ Render dotCMS pages using @dotcms/client
6 participants