Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set current user on viewtools velocity context for email subaction (#28352) #28373

Merged
merged 2 commits into from
Apr 30, 2024
Merged

set current user on viewtools velocity context for email subaction (#28352) #28373

merged 2 commits into from
Apr 30, 2024

Conversation

dsolistorres
Copy link
Contributor

Proposed Changes

  • Changed executeAction() method from EmailActionlet class to set the velocity context using the http request, that allow to the view tools list dotcontent to get the current user from the request attributes.
  • Added a new integration test to check that the velocity context has the appropriate user and dotcontent viewtool works as expected.

Checklist

  • Tests

@dsolistorres dsolistorres self-assigned this Apr 29, 2024
@dsolistorres dsolistorres linked an issue Apr 29, 2024 that may be closed by this pull request
Send Email sub-action doesn't set the current user to $dotcontent viewtool #28352
Closed
@dotcms-sonarqube dotCMS-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
12 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@erickgonzalez erickgonzalez added this pull request to the merge queue Apr 30, 2024
Merged via the queue into master with commit 5ee7692 Apr 30, 2024
26 checks passed
@erickgonzalez erickgonzalez deleted the issue-28352-fix-velocity-context-for-email-subaction branch April 30, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickgonzalez erickgonzalez erickgonzalez approved these changes

@nollymar nollymar nollymar approved these changes

@jdotcms jdotcms jdotcms approved these changes

Assignees

@dsolistorres dsolistorres

Labels
None yet
Projects
dotCMS - Product Planning
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Send Email sub-action doesn't set the current user to $dotcontent viewtool
4 participants
@dsolistorres @erickgonzalez @nollymar @jdotcms