New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 27725 adding validations for other fields #28349
Merged
erickgonzalez
merged 11 commits into
master
from
issue-27725-Adding-validations-for-other-fields
Apr 30, 2024
Merged
Issue 27725 adding validations for other fields #28349
erickgonzalez
merged 11 commits into
master
from
issue-27725-Adding-validations-for-other-fields
Apr 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neehakethi
force-pushed
the
issue-27725-Adding-validations-for-other-fields
branch
from
April 24, 2024 19:04
7920bbd
to
2150866
Compare
Co-authored-by: Will Ezell <will@dotcms.com>
Co-authored-by: KevinDavilaDotCMS <kfariid@gmail.com>
Co-authored-by: Daniel Colina <daniel.colina@dotcms.com>
Co-authored-by: Daniel Colina <daniel.colina@dotcms.com>
* Updated logic to hide ema-tools menu * Added missing message on save content from inline editing --------- Co-authored-by: KevinDavilaDotCMS <kfariid@gmail.com> Co-authored-by: Jalinson Diaz <zjaaaldev@gmail.com>
jdotcms
approved these changes
Apr 25, 2024
dsolistorres
approved these changes
Apr 25, 2024
erickgonzalez
approved these changes
Apr 29, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Apr 29, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Apr 30, 2024
Quality Gate passedIssues Measures |
erickgonzalez
deleted the
issue-27725-Adding-validations-for-other-fields
branch
April 30, 2024 21:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we have the validation for those fields, but we are still having the same problems with the middle name, nickname, and birthday fields.
Added the validations for fields middle name, nickName, and Birthday fields.