-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(edit-page-v2): Fix Live Preview Link #28329
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zJaaal
requested review from
fmontes,
hmoreras,
rjvelazco,
oidacra and
KevinDavilaDotCMS
and removed request for
fmontes and
hmoreras
April 23, 2024 15:27
…b.com/dotCMS/core into 28220-edit-page-v2-fix-live-page-link
zJaaal
changed the title
fix(edit-page-v2): Fix Live Page Link
fix(edit-page-v2): Fix Live Preview Link
Apr 23, 2024
KevinDavilaDotCMS
approved these changes
Apr 23, 2024
fmontes
approved these changes
Apr 25, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Screenshots
New Editor Headless
Screen.Recording.2024-04-23.at.3.50.12.PM-1.mov
New Editor VTL (The cannot GET Error is due to the Proxy we use to Hot Reload changes in Angular)
Screen.Recording.2024-04-23.at.3.52.09.PM-1.mov
Old Editor (Same error as above)
Screen.Recording.2024-04-23.at.3.55.07.PM-1.mov