Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(edit-page-v2): Fix Live Preview Link #28329

Merged
merged 13 commits into from
Apr 25, 2024

Conversation

zJaaal
Copy link
Contributor

@zJaaal zJaaal commented Apr 23, 2024

Proposed Changes

  • Add selector to handle the Preview URL
  • Make fallback to add origin in case is not specified in the URL passed to the component

Screenshots

New Editor Headless

Screen.Recording.2024-04-23.at.3.50.12.PM-1.mov

New Editor VTL (The cannot GET Error is due to the Proxy we use to Hot Reload changes in Angular)

Screen.Recording.2024-04-23.at.3.52.09.PM-1.mov

Old Editor (Same error as above)

Screen.Recording.2024-04-23.at.3.55.07.PM-1.mov

@zJaaal zJaaal linked an issue Apr 23, 2024 that may be closed by this pull request
@zJaaal zJaaal requested review from fmontes, hmoreras, rjvelazco, oidacra and KevinDavilaDotCMS and removed request for fmontes and hmoreras April 23, 2024 15:27
@zJaaal zJaaal changed the title fix(edit-page-v2): Fix Live Page Link fix(edit-page-v2): Fix Live Preview Link Apr 23, 2024
@fmontes fmontes enabled auto-merge April 25, 2024 12:49
@fmontes fmontes added this pull request to the merge queue Apr 25, 2024
Merged via the queue into master with commit 60fc0b8 Apr 25, 2024
15 checks passed
@fmontes fmontes deleted the 28220-edit-page-v2-fix-live-page-link branch April 25, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Edit Page V2: Fix Live Page Link
3 participants