Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(edit-page-2): Allow drag and drop functionality for images in dotcms #28249

Conversation

zJaaal
Copy link
Contributor

@zJaaal zJaaal commented Apr 16, 2024

Proposed Changes

  1. Refactor to unify drag and drop events in just one pipeline in the editor
  2. Handle the uploading of temporal file
  3. Handle the publishing of the temporal file
  4. Advice the user of errors (Dropped files different that images or failed uploading the image)

Screenshots

VTL Pages

Screen.Recording.2024-04-22.at.5.32.31.PM-1.mov

Headless

Screen.Recording.2024-04-22.at.5.39.10.PM-1.mov

@zJaaal zJaaal requested a review from oidacra April 23, 2024 14:22
@zJaaal zJaaal requested a review from rjvelazco April 23, 2024 16:51
@fmontes fmontes changed the title chore(edit page v2): Allow drag and drop functionality for images in dotcms feat(edit-page-2): Allow drag and drop functionality for images in dotcms Apr 26, 2024
@fmontes fmontes enabled auto-merge April 26, 2024 12:47
@zJaaal zJaaal dismissed rjvelazco’s stale review April 29, 2024 15:23

Already solved all the comments.

@fmontes fmontes added this pull request to the merge queue Apr 29, 2024
Merged via the queue into master with commit 22206eb Apr 29, 2024
26 checks passed
@fmontes fmontes deleted the 28039-edit-page-v2-allow-drag-and-drop-functionality-for-images-in-dotcms branch April 29, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Edit Page V2: Allow Drag and Drop Functionality for Images in dotCMS
5 participants