Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit Page V2: Enhance performance in Contentlet Tools #28331

Closed
Tracked by #27546
zJaaal opened this issue Apr 23, 2024 · 2 comments · Fixed by #28387
Closed
Tracked by #27546

Edit Page V2: Enhance performance in Contentlet Tools #28331

zJaaal opened this issue Apr 23, 2024 · 2 comments · Fixed by #28387
Assignees
@zJaaal
Labels
OKR : Technical User Experience Owned by Freddy Priority : 3 Average QA : Approved Release : 24.05.13 Bug Fixing Team : Lunik Type : Task

Comments

@zJaaal
Copy link
Contributor

zJaaal commented Apr 23, 2024 •
edited

Parent Issue

#27546

Task

Transform getXYZPosition functions to optimize DOM Rendening in Contentlet Tools

Proposed Objective

Technical User Experience

Proposed Priority

Priority 3 - Average

Acceptance Criteria

  • We should refactor all functions that are triggering in the HTML
  • Contentlet Tools should work as expected after the refactor

Assumptions & Initiation Needs

  • You understand the impact of triggering functions inside angular templates
This was referenced Apr 23, 2024
Open
Merged
@zJaaal zJaaal self-assigned this Apr 30, 2024
@zJaaal zJaaal linked a pull request Apr 30, 2024 that will close this issue
chore(edit-page-2): Enhance performance in contentlet tools #28331 #28387
Merged
github-merge-queue bot pushed a commit that referenced this issue May 6, 2024
@zJaaal
chore(edit-page-2): Enhance performance in contentlet tools #28331 (#…
3152c9c 
…28387)

* refactor to not make function calls inside the HTML

* add consts

* Update ema-contentlet-tools.component.ts
@rjvelazco
Copy link
Contributor

Passed Internal QA

  • Tested on Docker Image: [dotcms/trunk_5921e6a]

Video

iqa-28331-edit-page-v2-enhance-performance-in-contentlet-tools-1.mov

@bryanboza
Copy link
Member

Fixed, tested on the last trunk // Docker // FF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zJaaal zJaaal

Labels
OKR : Technical User Experience Owned by Freddy Priority : 3 Average QA : Approved Release : 24.05.13 Bug Fixing Team : Lunik Type : Task
Projects
dotCMS - Product Planning
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(edit-page-2): Enhance performance in contentlet tools #28331 dotCMS/core
3 participants
@bryanboza @zJaaal @rjvelazco