Skip to content

Commit

Permalink
#27634: Image AI: Migrate logic to a dialog and add accordions for se…
Browse files Browse the repository at this point in the history
…ttings and prompt. (#27913)

* initial progress

* initial progress

* clean up accordion styles

* progress

* progress

* progress

* progress

* progress

* adding labels and split to gallery component

* adding labels and split to gallery component

* testing eslint validation

* eslint test

* remove files

* loading rules ready for first demo

* loading rules ready for first demo

* test progress and mock of splitbutton

* test progress and mock of splitbutton

* code clean up & comment primeng styles

* add test and fix details

* feedback part 1

* feedback part 1

* feedback 2

* feedback 2

* feedback

* feedback

* feedback

* lint missing cheks
  • Loading branch information
hmoreras committed Mar 14, 2024
1 parent 6e0fce1 commit d404bc1
Show file tree
Hide file tree
Showing 33 changed files with 1,163 additions and 609 deletions.
@@ -0,0 +1,50 @@
import { Meta, Story } from '@storybook/angular';

import { BrowserAnimationsModule } from '@angular/platform-browser/animations';

import { Accordion, AccordionModule } from 'primeng/accordion';

export default {
title: 'PrimeNG/Panel/Accordion',
component: Accordion,
args: { activeIndex: 0, expandIcon: 'pi pi-angle-down', collapseIcon: 'pi pi-angle-up' },
parameters: {
docs: {
description: {
component:
'Accordion groups a collection of contents in tabs.: https://www.primefaces.org/primeng-v15-lts/accordion'
}
}
}
} as Meta;

const BasicTemplate = `
<p-accordion [activeIndex]="activeIndex" [expandIcon]="expandIcon" [collapseIcon]="collapseIcon">
<p-accordionTab header="Header I" iconPos="end">
<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation
ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur.
Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.</p>
</p-accordionTab>
<p-accordionTab header="Header II" iconPos="end" >
<p>Sed ut perspiciatis unde omnis iste natus error sit voluptatem accusantium doloremque laudantium, totam rem aperiam, eaque ipsa quae ab illo inventore veritatis et quasi
architecto beatae vitae dicta sunt explicabo. Nemo enim ipsam voluptatem quia voluptas sit aspernatur aut odit aut fugit, sed quia consequuntur magni dolores eos qui ratione
voluptatem sequi nesciunt. Consectetur, adipisci velit, sed quia non numquam eius modi.</p>
</p-accordionTab>
<p-accordionTab header="Header III" iconPos="end" [disabled]="true">
<p>At vero eos et accusamus et iusto odio dignissimos ducimus qui blanditiis praesentium voluptatum deleniti atque corrupti quos dolores et quas molestias excepturi sint occaecati
cupiditate non provident, similique sunt in culpa qui officia deserunt mollitia animi, id est laborum et dolorum fuga. Et harum quidem rerum facilis est et expedita distinctio.
Nam libero tempore, cum soluta nobis est eligendi optio cumque nihil impedit quo minus.</p>
</p-accordionTab>
</p-accordion>`;

export const Main: Story = (args) => {
return {
props: {
activeIndex: args.activeIndex,
expandIcon: args.expandIcon,
collapseIcon: args.collapseIcon
},
moduleMetadata: { imports: [AccordionModule, BrowserAnimationsModule] },
template: BasicTemplate
};
};
Expand Up @@ -68,7 +68,6 @@ import {
DotMarketingConfigService,
formatHTML,
removeInvalidNodes,
removeLoadingNodes,
RestoreDefaultDOMAttrs,
SetDocAttrStep
} from '../../shared';
Expand Down Expand Up @@ -485,19 +484,10 @@ export class DotBlockEditorComponent implements OnInit, OnDestroy, ControlValueA
}

private setEditorJSONContent(content: Content) {
//TODO: remove this when the AI content is generated exclusively in popups and not in the editor directly.
const filterContent = removeLoadingNodes(
content
? Array.isArray(content)
? [...content]
: [...(content as JSONContent).content]
: []
);

this.content =
this.allowedBlocks?.length > 1
? removeInvalidNodes(filterContent, this.allowedBlocks)
: filterContent;
? removeInvalidNodes(content, this.allowedBlocks)
: content;
}

private setEditorContent(content: Content) {
Expand Down
Expand Up @@ -10,12 +10,9 @@ import { takeUntil } from 'rxjs/operators';

import { Editor } from '@tiptap/core';

import { getAIPlaceholderImage } from '../../../shared';
import { DOT_AI_TEXT_CONTENT_KEY } from '../../ai-content-prompt/ai-content-prompt.extension';
import { AiContentPromptStore } from '../../ai-content-prompt/store/ai-content-prompt.store';
import { DOT_AI_IMAGE_CONTENT_KEY } from '../../ai-image-prompt/ai-image-prompt.extension';
import { DotAiImagePromptStore } from '../../ai-image-prompt/ai-image-prompt.store';
import { AI_IMAGE_PLACEHOLDER_PROPERTY } from '../../ai-image-prompt/plugins/ai-image-prompt.plugin';
import { ACTIONS, AIContentActionsComponent } from '../ai-content-actions.component';
import { AI_CONTENT_ACTIONS_PLUGIN_KEY } from '../ai-content-actions.extension';
import { TIPPY_OPTIONS } from '../utils';
Expand Down Expand Up @@ -152,20 +149,6 @@ export class AIContentActionsView {
case DOT_AI_TEXT_CONTENT_KEY:
this.aiContentPromptStore.setAcceptContent(true);
break;

case DOT_AI_IMAGE_CONTENT_KEY:
// eslint-disable-next-line no-case-declarations
const placeholder = getAIPlaceholderImage(this.editor);

delete placeholder.node.attrs.data[AI_IMAGE_PLACEHOLDER_PROPERTY];

this.view.dispatch(
this.view.state.tr.setNodeMarkup(placeholder.from, undefined, {
data: placeholder.node.attrs.data
})
);

break;
}
}

Expand All @@ -178,10 +161,6 @@ export class AIContentActionsView {
case DOT_AI_TEXT_CONTENT_KEY:
this.aiContentPromptStore.reGenerateContent();
break;

case DOT_AI_IMAGE_CONTENT_KEY:
this.dotAiImagePromptStore.reGenerateContent();
break;
}
}

Expand All @@ -191,16 +170,6 @@ export class AIContentActionsView {
case DOT_AI_TEXT_CONTENT_KEY:
this.aiContentPromptStore.setDeleteContent(true);
break;

case DOT_AI_IMAGE_CONTENT_KEY:
// eslint-disable-next-line no-case-declarations
const placeholder = getAIPlaceholderImage(this.editor);
this.editor.commands.deleteRange({
from: placeholder.from,
to: placeholder.to
});

break;
}

this.editor.commands.closeAIContentActions();
Expand Down
Expand Up @@ -4,28 +4,35 @@
[dismissableMask]="true"
[draggable]="false"
[resizable]="false"
[style]="{ width: '800px' }"
(onHide)="hideDialog()"
[style]="{ width: '1040px' }"
(onHide)="store.hideDialog()"
appendTo="body"
header="{{ 'block-editor.extension.ai-image.dialog-title' | dm }}">
<div class="dialog-prompts__wrapper grid">
<dot-ai-image-prompt-input
class="col"
[isLoading]="vm.status === ComponentStatus.LOADING"
[selected]="vm.selectedPromptType === 'input'"
(click)="selectType('input', vm.selectedPromptType)"
(promptChanged)="generateImage($event)"
placeholder="{{ 'block-editor.extension.ai-image.input-text.placeholder' | dm }}"
type="input" />

<dot-ai-image-prompt-input
class="col"
[isLoading]="vm.status === ComponentStatus.LOADING"
[selected]="vm.selectedPromptType === 'auto'"
(click)="selectType('auto', vm.selectedPromptType)"
(promptChanged)="generateImage($event)"
placeholder="{{ 'block-editor.extension.ai-image.auto-text.placeholder' | dm }}"
type="auto" />
<div class="dialog-prompt__wrapper">
<dot-ai-image-prompt-form
*ngIf="vm.showDialog"
[generatedValue]="vm.images[vm.galleryActiveIndex]"
[isLoading]="vm.isLoading"
(value)="store.generateImage($event)"
(orientation)="vm.orientation = $event" />
<div [class.dialog-prompt_gallery]="vm.images.length || vm.isLoading">
<dot-ai-image-prompt-gallery
[isLoading]="vm.isLoading"
[images]="vm.images"
[activeImageIndex]="vm.galleryActiveIndex"
[orientation]="vm.orientation"
(activeIndexChange)="vm.galleryActiveIndex = $event" />
<button
class="align-self-end"
*ngIf="vm.images.length || vm.isLoading"
[disabled]="vm.isLoading"
[label]="'block-editor.extension.ai-image.insert' | dm"
(click)="store.setSelectedImage(vm.images[vm.galleryActiveIndex])"
data-testid="submit-btn"
pButton
type="submit"
icon="pi pi-check"></button>
</div>
</div>
</p-dialog>
</ng-container>
Expand Down
@@ -1,5 +1,20 @@
@use "variables" as *;

.dialog-prompts__wrapper {
.dialog-prompt__wrapper {
gap: $spacing-5;
display: grid;
grid-template-columns: 1fr 1fr;

> * {
display: flex;
flex-direction: column;
flex: 1;
justify-content: center;
}
}

.dialog-prompt_gallery {
> * {
margin-top: auto;
}
}
@@ -1,28 +1,85 @@
import { HttpClientTestingModule } from '@angular/common/http/testing';
import { ComponentFixture, TestBed } from '@angular/core/testing';
import { ReactiveFormsModule } from '@angular/forms';
import { byTestId, createComponentFactory, Spectator } from '@ngneat/spectator';
import { of } from 'rxjs';

import { Dialog } from 'primeng/dialog';

import { AIImagePromptComponent } from './ai-image-prompt.component';
import { DotAiImagePromptStore } from './ai-image-prompt.store';
import { AiImagePromptFormComponent } from './components/ai-image-prompt-form/ai-image-prompt-form.component';

import { DotAiService } from '../../shared';
import {
AIImagePrompt,
DotAIImageOrientation,
DotGeneratedAIImage
} from '../../shared/services/dot-ai/dot-ai.models';

describe('AIImagePromptComponent', () => {
let component: AIImagePromptComponent;
let fixture: ComponentFixture<AIImagePromptComponent>;

beforeEach(async () => {
await TestBed.configureTestingModule({
imports: [ReactiveFormsModule, HttpClientTestingModule],
declarations: [AIImagePromptComponent],
providers: [DotAiService]
}).compileComponents();

fixture = TestBed.createComponent(AIImagePromptComponent);
component = fixture.componentInstance;
fixture.detectChanges();
let spectator: Spectator<AIImagePromptComponent>;
let store: DotAiImagePromptStore;

const imagesMock: DotGeneratedAIImage[] = [
{ name: 'image1', url: 'image_url' },
{ name: 'image2', url: 'image_url_2' }
] as unknown as DotGeneratedAIImage[];

const createComponent = createComponentFactory({
component: AIImagePromptComponent,
providers: [
{
provide: DotAiImagePromptStore,
useValue: {
vm$: of({
showDialog: true,
isLoading: false,
images: imagesMock,
galleryActiveIndex: 0,
orientation: DotAIImageOrientation.VERTICAL
}),
generateImage: jasmine.createSpy('generateImage'),
hideDialog: jasmine.createSpy('hideDialog'),
patchState: jasmine.createSpy('patchState'),
cleanError: jasmine.createSpy('cleanError')
}
}
]
});

beforeEach(() => {
spectator = createComponent();
store = spectator.inject(DotAiImagePromptStore);
});

it('should hide dialog', () => {
const dialog = spectator.query(Dialog);
dialog.onHide.emit('true');
expect(store.hideDialog).toHaveBeenCalled();
});

it('should generate image', () => {
const promptForm = spectator.query(AiImagePromptFormComponent);
const formMock: AIImagePrompt = {
text: 'Test',
type: 'input',
size: DotAIImageOrientation.VERTICAL
};

promptForm.value.emit(formMock);

expect(store.generateImage).toHaveBeenCalledWith(formMock);
});

it('should inset image', () => {
const submitBtn = spectator.query(byTestId('submit-btn'));

spectator.click(submitBtn);
expect(store.patchState).toHaveBeenCalledWith({
selectedImage: imagesMock[0]
});
});

it('should create', () => {
expect(component).toBeTruthy();
it('should clear error on hide confirm', () => {
const dialog = spectator.query(Dialog);
dialog.onHide.emit('true');
expect(store.cleanError).toHaveBeenCalled();
});
});

0 comments on commit d404bc1

Please sign in to comment.