Skip to content

Commit a2b0f04

Browse files
authored
Merge pull request #10 from doomedcat17/development
- SCPierApiException.java created
2 parents 78cca0e + 17a189e commit a2b0f04

File tree

5 files changed

+15
-13
lines changed

5 files changed

+15
-13
lines changed

src/main/java/com/doomedcat17/scpier/ScpFoundationDataProvider.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@
44
import com.doomedcat17.scpier.data.scp.SCPTranslation;
55
import com.doomedcat17.scpier.data.scp.ScpWikiData;
66
import com.doomedcat17.scpier.exception.SCPWikiContentNotFound;
7-
import com.doomedcat17.scpier.exception.ScpierIternalException;
7+
import com.doomedcat17.scpier.exception.SCPierApiException;
8+
import com.doomedcat17.scpier.exception.SCPierApiInternalException;
89
import com.doomedcat17.scpier.mapper.scp.ScpMapperProvider;
910
import com.doomedcat17.scpier.mapper.scp.ScpWikiContentMapper;
1011
import com.doomedcat17.scpier.page.PageContent;
@@ -14,7 +15,7 @@ public class ScpFoundationDataProvider {
1415

1516
private final PageContentProvider pageContentProvider = new PageContentProvider();
1617

17-
public ScpWikiData getScpWikiData(String articleName, SCPBranch scpBranch, SCPTranslation scpTranslation) throws SCPWikiContentNotFound, ScpierIternalException {
18+
public ScpWikiData getScpWikiData(String articleName, SCPBranch scpBranch, SCPTranslation scpTranslation) throws SCPierApiException {
1819
try {
1920
PageContent pageContent = getPageContent(articleName, scpBranch, scpTranslation);
2021
ScpWikiContentMapper scpWikiContentMapper = ScpMapperProvider.getScpMapper(pageContent.getName());
@@ -23,7 +24,7 @@ public ScpWikiData getScpWikiData(String articleName, SCPBranch scpBranch, SCPTr
2324
return scpWikiData;
2425
} catch (RuntimeException e) {
2526
e.printStackTrace();
26-
throw new ScpierIternalException(articleName, scpBranch, scpTranslation);
27+
throw new SCPierApiInternalException(articleName, scpBranch, scpTranslation);
2728
}
2829
}
2930

src/main/java/com/doomedcat17/scpier/exception/SCPWikiContentNotFound.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package com.doomedcat17.scpier.exception;
22

3-
public class SCPWikiContentNotFound extends Exception {
3+
public class SCPWikiContentNotFound extends SCPierApiException {
44
public SCPWikiContentNotFound(String message) {
55
super("Requested content is not available: "+message);
66
}
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
package com.doomedcat17.scpier.exception;
2+
3+
public class SCPierApiException extends Exception{
4+
5+
public SCPierApiException(String message) {
6+
super(message);
7+
}
8+
}

src/main/java/com/doomedcat17/scpier/exception/ScpierIternalException.java renamed to src/main/java/com/doomedcat17/scpier/exception/SCPierApiInternalException.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
import com.doomedcat17.scpier.data.scp.SCPBranch;
44
import com.doomedcat17.scpier.data.scp.SCPTranslation;
55

6-
public class ScpierIternalException extends Exception {
7-
public ScpierIternalException(String name, SCPBranch scpBranch, SCPTranslation scpTranslation) {
6+
public class SCPierApiInternalException extends SCPierApiException {
7+
public SCPierApiInternalException(String name, SCPBranch scpBranch, SCPTranslation scpTranslation) {
88
super("Please, submit this error to scpier github issues section! https://github.com/doomedcat17/scpier/issues\n" +
99
"Name: "+name+", Branch: "+scpBranch+", Translation: "+scpTranslation);
1010
}

src/main/java/com/doomedcat17/scpier/exception/ScpTaleMapperException.java

Lines changed: 0 additions & 7 deletions
This file was deleted.

0 commit comments

Comments
 (0)