update readme to better explain 'store kit flow' #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update readme to better explain the use of addAdditionalSuccessPurchaseListenerIOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you for this package and for the time you invested in it!
This is related to #307.
This PR tries to make the readme clearer regarding the motivation and use of the
addAdditionalSuccessPurchaseListenerIOSmethod.The current readme makes it seem like calling
addAdditionalSuccessPurchaseListenerIOSis optional, but it's not. If I decide not to support the 'store kit flow', my application can end up receiving payment from users but not acknowledging it.I think you wanted to have the example as simple as possible so I tried to do so, while still providing example code on how to handle the 'store kit flow'.
Happy to hear feedback about this