Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Send purchase-updated instead of purchase-update. #2739

Merged
merged 3 commits into from May 23, 2024

Conversation

dwyery
Copy link
Contributor

@dwyery dwyery commented May 10, 2024

During some testing of restoring purchases using the getAvailablePurchases method with the alsoPublishToEventListener argument set to true I noticed that the events were not being published correctly. I also noticed in the logs an error message saying that purchase-update was not a supported event.

I had a look at the code in RNIapIosSk2.swift and it appears that the event name should actually be purchase-updated.

I fixed this locally and the error no longer appears and the purchase is now being published to the event listener.

Creating this as a draft PR as I am not too sure if there is anything else I need to do, this is my first contribution to the project.

@dwyery
Copy link
Contributor Author

dwyery commented May 10, 2024

Looks like the build is failing with:

Run swiftlint lint --fix --format --path ios/*.swift --config .swiftlint.yml

/Users/runner/work/_temp/cc0d47bb-9bc0-431a-bb28-0434ffd4767d.sh: line 1: swiftlint: command not found

Is there something I am missing?

@dwyery dwyery marked this pull request as ready for review May 15, 2024 13:05
@hyochan
Copy link
Member

hyochan commented May 23, 2024

Looks like the build is failing with:

Run swiftlint lint --fix --format --path ios/*.swift --config .swiftlint.yml

/Users/runner/work/_temp/cc0d47bb-9bc0-431a-bb28-0434ffd4767d.sh: line 1: swiftlint: command not found

Is there something I am missing?

It is weird that swiftlint isn't preinstalled in recent macos image. I've added brew install swiftlint step.

Copy link
Member

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hyochan hyochan merged commit 6ea0cc7 into dooboolab-community:main May 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants