Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional success purchase listener ios #58

Merged
merged 4 commits into from Jan 29, 2019

Conversation

hyochan
Copy link
Member

@hyochan hyochan commented Jan 28, 2019

This feature came from the support of feature in react-native-iap. Related issue in #307.

Related issue in current repo: #54

Description

  • Unlike what I've done in react-native-iap, I've tried to manage rejection inside plugin so that additional success event will be received in the method itself and hopefully delivered to buyProduct and buySubscription.
  • Also, deprecate buyProductWithoutFinishTransanction when this feature is implemented.

Set implicit-casts true only.
This is similar feature from react-native-iap(dooboolab-community/react-native-iap#307). Similar issue in current repo #54.
Similar to buyProduct. Do this in buySubscription.
@mrmikezhang
Copy link

Thank you for letting me know @hyochan , I will try it out in my next release.

@hyochan
Copy link
Member Author

hyochan commented Jan 29, 2019

I will merge this and release 0.8.8+1.
I've tested this is not failing builds and previous feature.
Need to watch if it solves the real problem.

@hyochan hyochan merged commit d32ba9c into master Jan 29, 2019
@hyochan hyochan deleted the addAdditionalSuccessPurchaseListenerIOS branch January 29, 2019 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature ios ios related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants