Adds HubSpot analytics tracking code #678
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is this exactly? |
| (function(d,s,i,r) { | ||
| if (d.getElementById(i)){return;} | ||
| var n=d.createElement(s),e=d.getElementsByTagName(s)[0]; | ||
| n.id=i;n.src='//js.hs-analytics.net/analytics/'+(Math.ceil(new Date()/r)*r)+'/2171535.js'; |
There was a problem hiding this comment.
It looks like this is trying to prevent the script from being cached, I wonder why that is?
|
I think we should hold off on hubspot until we can analyze the performance. Tracking scripts have a tendency to hurt performance and we want to prevent that since that's what we sell with DoneJS. In particular I'd like to see:
|
|
I don't have any problem with this any more. Should we merge this? Still desirable? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.