Page orientation #613
Open
Page orientation #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsweeney
added a commit
that referenced
this pull request
Dec 8, 2014
This fixes the previous commit, which was causing an internal inconsistency between the Canvas and PDF properties of dompdf. We are still incomplete functionally since we are wiping out the instances of the Canvas and FontMetrics objects that were created on dompdf instantiation. Any actions taken on the canvas object prior to rendering (e.g. CPDF page scripts) are thus wiped out. We should integrate the code from #613 so that Dompdf/CPDF is able to set pages sizes dynamically. PDFLib support will have to be similarly updated.
Updates from master
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In regards to Issue 498, and with the code I posted on Google Groups:
https://groups.google.com/d/msg/dompdf/03akDzpb1mo/EsZQC0ain6AJ
I did notice an issue with Adobe Reader, whereby it wanted a pages->pages->page type structure.
I've fixed this and thought I'd have a go at a pull request.
In summary, this has resulted in some changes needing to be made to cpdf (for the 'pages' object to have a parent, and to count the children), and I've exposed the "new_document()" method via the dompdf class.
There is also an example file, which I've just dumped into a /testing/ folder for now.
Hope you find this useful.