FIX artifact path validation #3433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### There Is A Small Problem Instead Of: ~~public function validateArtifactPath(string $path, string $option)~~ We Should Use: `public function validateArtifactPath(?string $path, string $option)` The `PATH` might be `NULL` in some cases.
|
Apologies, that's a scenario I did not account for. There should be no need to set a path to null, but you are correct that it could happen. |
|
Apologies, I don't know where my head is right now. I had to re-re-release because the "2.0.x" branch was updated with master in preparation for merging. I reset the branch, the update is in 2.0.7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There Is A Small Problem
Instead Of:
public function validateArtifactPath(string $path, string $option)We Should Use:
public function validateArtifactPath(?string $path, string $option)The
PATHmight beNULLin some cases.