Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve vertical alignment and related adjustments #2762

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve vertical alignment and related adjustments #2762

wants to merge 2 commits into from

Commits on Apr 4, 2024

  1. Improve vertical alignment and related adjustments 

    This change simplifies the vertical alignment logic by using a consistent
frame of reference for djustments.

1. Determine the line baseline by calculating the "outer baseline" of the frames
   contained on the line.
2. For each frame on a line calculate the vertical alignment adjustment
3. Add the line height difference to the previous calculation
4. Re-position the frame per the calculated adjustment
4. Determine if the line height is adjusted after the frame is aligned
5. Re-position any following lines if the previous line height was adjusted

The outer baseline height calculation is cached to aid in performance
since this operation is performed inside-out after the frame has reflowed.
    @bsweeney
    bsweeney committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    5369d6c View commit details
    Browse the repository at this point in the history

  2. Adjust line positioning with block during reflow

    @bsweeney
    bsweeney committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    fd306ae View commit details
    Browse the repository at this point in the history