Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop PHP support older than 7.4 #2705

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

PowerKiKi
Copy link
Contributor

Because those are EOL, and this would solve the confusion expressed in dompdf/php-svg-lib#78 (comment)

Because those are EOL
@bsweeney bsweeney added this to the 2.0.0 milestone Dec 22, 2021
@Spreeuw
Copy link
Contributor

Spreeuw commented Dec 22, 2021

Dropping support for PHP 7.1/7.2/7.3 makes sense if you need to implement changes that can't be done on those versions - you can drop them when you release those changes. Dropping it just because it's EOL is not a strong argument to me.

@PowerKiKi
Copy link
Contributor Author

You cannot modernize code as long as you declare supporting old versions. Dropping those versions now means that any contributions, even the smallest one, can start using modern syntax. Stronger typings comes to mind first, but there are a lot of nice things in recent PHP versions that will never be naturally adopted if we don't drop support for old PHP version first.

@PowerKiKi
Copy link
Contributor Author

Also I'd like to remind that dropping PHP version is not a breaking change, and it can be release in a minor version just fine. Doctrine and PHPSpreadsheet are projects, amongst others, that do that routinely without any issues.

So this PR should target milestone 1.2.0, not 2.0.0.

@Mellthas
Copy link
Member

I see no actual benefit in dropping support with 1.2.0. The only advantage would be clearing up the possible confusion about the php-svg-lib dependency, which should only be an actual problem when using different PHP versions between different environments as described in the post that @PowerKiKi linked. And as mentioned there (Making sure you get a compatible version), that situation can be handled with the platform.config setting.

If php-svg-lib keeps the PHP 7.4 requirement, we could put a note about the setting into the release notes, and keep it until the PHP requirements for the latest versions are compatible between the projects again.

@bsweeney bsweeney removed this from the 2.0.0 milestone Mar 25, 2022
@bsweeney bsweeney added this to the 2.0.4 milestone May 3, 2023
@bsweeney bsweeney modified the milestones: 2.0.4, 2.0.5 Jun 9, 2023
@bsweeney bsweeney modified the milestones: 3.0.1, 4.0.0 Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants