Restrict base tag config to processHtml method #2458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is fix to #2452 . I'm new to this library and can't estimate possible side effects, so this is more a draft. Also there are no new tests, since I don't know how (I know PHP Unit, but not how things processed and stored by this library and the cache is cleared before the render method is finished).
This PR changes how the base tag content is processed. Instead of overriding the global protocol, baseHost and basePath properties, it introduces local variables. This will fix that local images are not loaded correct, if remote is disabled and a base tag is set (without a base tag css files are not loaded).