You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
Indeed, though deprecation is not indication of when the functionality will be removed those probably should have been removed with this release. I'll try to remember to review deprecated functionality in more detail for the next major release.
79573d8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bsweeney all the deprecated code was not deleted again
dompdf/src/Dompdf.php
Lines 324 to 326 in 71a1e1d
dompdf/src/Dompdf.php
Lines 497 to 499 in 71a1e1d
79573d8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, though deprecation is not indication of when the functionality will be removed those probably should have been removed with this release. I'll try to remember to review deprecated functionality in more detail for the next major release.