New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated to angular 17.1.2 #259
Open
manishsingh10895
wants to merge
5
commits into
dominique-mueller:develop
Choose a base branch
from
manishsingh10895:develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
updated to angular 17.1.2 #259
manishsingh10895
wants to merge
5
commits into
dominique-mueller:develop
from
manishsingh10895:develop
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update package version
Updated versions
update peer deps
Update peer deps
StepaZol
reviewed
Mar 24, 2024
@@ -1,7 +1,7 @@ | |||
{ | |||
"name": "angular-notifier", | |||
"description": "A well designed, fully animated, highly customizable, and easy-to-use notification library for your Angular application.", | |||
"version": "14.0.0", | |||
"version": "14.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you are adding breaking changes and the version should be 15
StepaZol
reviewed
Mar 24, 2024
Comment on lines
+16
to
+23
// Object.defineProperty(document.body.style, 'transform', { | ||
// value: () => { | ||
// return { | ||
// enumerable: true, | ||
// configurable: true, | ||
// }; | ||
// }, | ||
// }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it's no longer needed, why are you commenting this code? maybe remove it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated packages.
I ran
ncu
to update package versionsAlso this is first hacking around with jest in angular, and in
jest.setup.ts
line 16, updatingtransform
property threw an error on running tests.I have commented that code out, it works and as far as I google that workaround isn't needed anymore