-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BreakpointWidget: Add ability to directly edit breakpoints #12780
BreakpointWidget: Add ability to directly edit breakpoints #12780
Conversation
853e88f
to
e326228
Compare
I added it. Note that changing Dark/Light style doesn't send a signal to update, so you have to manually cause the widget to update if you want to test both styles. |
This is actually not what I meant. But this is a good change in any case. Per my screenshot above, I would expect row2 to be entirely grayed out as the 'active' is not checked. The idea was to indicate if a current BP is 'inactive' by implicit state - as this sort of solves the case of weird BP configurations and not realizing it. |
Oh, my bad. That's a nice idea to deal with weird states in the UI, if the text is still readable. I wonder if I can do it without setting the color for each cell. |
Yeah, im not sure if its feasible. Was just an idea. That aside, ive been using this build for a while now, its really a great improvement as is. |
dbacd53
to
dbacb60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested latest commit (dbacb60) a bunch in real world usage.
LGTM. While it would be nice to handle what we discussed above, it's not really detrimental to usage as is.
Maybe in a future PR.
I think this is worth merging as is.
dbacb60
to
f86a5a7
Compare
…l be removed, so select -> delete is hard to maintain.
3372654
to
bebbadc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been using this for about 2 weeks, with the latest (disable state UI state adjustment) for about a week. It's overall a much better debugging UX.
Thoroughly tested the disable color states for MBP. Everything looks good to me. I think this should be merged.
@sepalani Are you interested in reviewing? |
bebbadc
to
8343009
Compare
Squashed the fixup commits. I haven't tested this but if you say it works fine I'll believe you, it seems like a massive usability improvement. |
…nd fix OnContextMenu which relied on select rows. Add functions to edit breakpoints.
…ls from being affected.
(bug?) Does not update on dark/light style change, as no signals are sent.
8343009
to
3526f3c
Compare
Add theme-aware buttons, ability to edit addresses, and a popup for conditional editing.
If a base address is changed, it will delete the breakpoint and then create a new breakpoint at the new address. Useful for moving a conditional to another address.
Removed selecting rows, which breaks the old delete button. Delete moved to context menu.
This new style can result in new odd states for breakpoints. Such as a Memory Breakpoint that is enabled, but has Read + Write disabled, resulting in nothing being done. Previously Read and/or Write would always be true. Not sure it matters.
If the buttons are no good, they can be replaced with 3-state combo boxes. Break/Log/B+L.