Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing #4182, since PR has been compromised by anti-ransomware mass-deleted and re-added files on my environment. Here's some important points.
Currently, Korean romanization does not work properly, since
romanize()
inClean.php
does not handle full character. It only works when we type each component individually(ex. ㅌㅔㅅㅡㅌㅡ), which is virtually useless.So I added function for decomposing Korean characters and romanize them accordingly.
However, here's the catch.
strtr
.I thought this PR needs some discussion or review, so I opened as draft. (This code works though.)
I implemented dedicated Korean test, with most frequently used words provided by National Institute of the Korean Language.
This implementation does spelling-based romanization, which is not official romanization of Korean(which uses pronounciation-based). However, pronounciation-based romanization is much more complicated and I think this relatively simple implementation works fine for the purpose.
As far as I know, other project(OpenProject) also uses this kind of romanization, but I can't surely confirm.