Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix listblock preformatted overlap #4055

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix listblock preformatted overlap #4055

wants to merge 4 commits into from

Commits on Sep 11, 2023

  1. Allow lexer to replace newlines consumed by block exit 

    Some blocks (e.g. listblocks and preformatted) consume newlines in their exit pattern.  Some blocks (e.g. listblocks and preformatted) need newlines in their *entry* patterns, but that newline was consumed by the previous block!  This updates the lexer to put the newline back when exiting a block consumes the newline.
    @fts-tmassey
    fts-tmassey committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    a6cb7e6 View commit details
    Browse the repository at this point in the history

  2. Update preformatted addPattern to match addEntryPattern 

    The entry pattern for preformatted blocks understand and respect listblocks, but the mid-block pattern does not.  The syntax is the same, so the pattern match should be the same.  Otherwise, preformatted blocks will accidentally turn subsequent listblock lines into preformatted!
    @fts-tmassey
    fts-tmassey committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    8f71754 View commit details
    Browse the repository at this point in the history

  3. use isModeEnd() instead of a hard-coded string

    @fts-tmassey
    fts-tmassey committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    792a0f3 View commit details
    Browse the repository at this point in the history

  4. Use str_ends_with

    @fiwswe
    fiwswe committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    1d14c80 View commit details
    Browse the repository at this point in the history