Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SubscriptionSender: Send mail to each subscriber individually #4035

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tomabrafix
Copy link
Contributor

Some recipients (especially mailing lists) do not accept mails if the recipient is not listed in the To-header. With this commit each mail will be sent individually with the email address as To instead of Bcc to preserve privacy.

Fixes #1422

Some recipients (especially mailing lists) do not accept mails if the
recipient is not listed in the To-header. With this commit each mail
will be sent individually with the email address as To instead of Bcc
to preserve privacy.

Fixes dokuwiki#1422
@fiwswe
Copy link
Collaborator

fiwswe commented Aug 20, 2023

So if 2 wiki subscribers are subscribed to the same mailing list, the list would receive the same message (as separate unrelated emails) twice?

Not sure if that is a good idea.

@fiwswe
Copy link
Collaborator

fiwswe commented Aug 20, 2023

No sorry, I take that back. For this to happen the mailing list address would need to be subscribed to the wiki multiple times, not the wiki users themselves. This should not normally be possible.

@splitbrain
Copy link
Collaborator

Theoretically, this is a good approach. However mails may be sent synchronously during the save operation. When a hundred people are subscribed to the article (or namespace) a hundred mails will be sent to the mail server (depending on the setup either via the sendmail binary which will feed a unix socket (somewhat fast) or via SMTP (slower). I haven't timed it but I suspect this could quickly run into PHP's timelimit...

@tomabrafix
Copy link
Contributor Author

Maybe a solution is to make this configurable for now?

We noticed at our instances that a large part of the bounced mails are rejected because the mail does not contain the recipients mail address in the To or the CC header. This change fixed that without compromising privacy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mail blocked due to missing "To:" header
3 participants