Avoid some unnecessary index file writes. #3860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
word_idx modified should be reset to false for each word index file, or all unchanged word index files after the first changed one will be resaved unnecessarily.
|
Well spotted! If you're interested in working some more on the index, have a look at #3810 and it's predecessors which aims to rewrite the whole indexing mechanism to be cleaner and reusable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variable
word_idx modifiedin thegetPageWordsindexer method should be reset to false for each word index file, or all unchanged word index files after the first changed one will be resaved unnecessarily.