Test Autoloading Cleanup #3812
Test Autoloading Cleanup #3812
Conversation
This replaces my attempt in 12ebce9 The canonical namespace for DokuWiki core tests is dokuwiki/test/ and this is mapped to _test/tests now in the autoloader. This means the majority of tests is in the dokuwiki/test/inc namespace. Mockfiles are located at _test/mock and have the namespace dokuwiki/test/mock - if that's good or bad is debatable. I simply kept it as it always has been. But there might be an argument for having mock objects closer to the tests that use them (eg. right next to the test files).
This adds the test namespace to those test classes that are already in PSR4 format.
|
BTW. IntelliJ Idea can be set up to be aware of different Namespaces using the Modules Settings (can be opened with F4 when focused on the file tree). You can mark folders as Sources or Tests, then use the pen icon next to it on the right to configure the namespace associated with it. Here's an example from my setup:
This should be added to the docs at https://www.dokuwiki.org/devel:unittesting when this is merged. |
|
Hmm. Having merged this, I wanted to update the documentation and discovered that I'm still not happy with how this works. Currently (with this patch applied) |
Having "inc" in the namespace is awkward. Instead the test class namespaces now correspond to their real class namespaces. With further refactorings we should get rid of most of the stuff in tests/inc this is a continuation of #3812
|
Nice that you made it more uniform. I did not realize that the dev plugin could add the needed boilerplate quickly, thanks for the docs update as well. |
Namespacing and autoloading for our tests was a bit messed up. Some classes used the wrong
testsnamespace instead of the properdokuwiki\testnamespace. Our autoloader did not correctly map the namespace to_test\testseither. This all didn't matter much as long as no test wanted to inherit from or use a sibling test - a problem I encountered while working on #3810. The fix suggested there in 12ebce9 however was too shortsighted and does not work as intended.This PR fixes the autoloading properly and updates the namespaces for those tests that already use a PSR4 style naming. Others will need renaming later on.