-
-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SearchIndex: Implement Collections (WIP) #3810
Draft
splitbrain
wants to merge
9
commits into
searchIndex-restructure
Choose a base branch
from
searchIndex-collections
base: searchIndex-restructure
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Commits on Sep 11, 2022
-
keep modification state of MemoryIndexes
MemoryIndexes only need to be saved back when they have been modified
Configuration menu - View commit details
-
Copy full SHA for b3cb0bc - Browse repository at this point
Copy the full SHA b3cb0bcView commit details -
Add a first collection based on the old FullText Index
This collection is meant as a base class for fulltext indexes, a page specific implementation will follow. Currently contains lots of dead code that needs to be removed or replaced.
Configuration menu - View commit details
-
Copy full SHA for 1ca6792 - Browse repository at this point
Copy the full SHA 1ca6792View commit details
Commits on Sep 12, 2022
-
Namespace based loading for core tests did not work as intended (but hasn't been used so far)
Configuration menu - View commit details
-
Copy full SHA for 12ebce9 - Browse repository at this point
Copy the full SHA 12ebce9View commit details -
Use base class for searchIndex tests
Many tests are the same for File and Memory indexes
Configuration menu - View commit details
-
Copy full SHA for 6a086a5 - Browse repository at this point
Copy the full SHA 6a086a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 03a3563 - Browse repository at this point
Copy the full SHA 03a3563View commit details
Commits on Sep 14, 2022
-
Configuration menu - View commit details
-
Copy full SHA for f5f947e - Browse repository at this point
Copy the full SHA f5f947eView commit details
Commits on May 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9f63f00 - Browse repository at this point
Copy the full SHA 9f63f00View commit details
Commits on May 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7fcedc3 - Browse repository at this point
Copy the full SHA 7fcedc3View commit details
Commits on May 11, 2023
-
Working fulltext collection and search
This finalizes the FulltextCollection and FulltextCollectionSearch classes. Proper locking is implemented, tests have been enhanced. It should be possible to reimplement the page full text search on top of it.
Configuration menu - View commit details
-
Copy full SHA for 596d528 - Browse repository at this point
Copy the full SHA 596d528View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.